added unit tests for Element.Layout.toObject

RStankov · Apr 19, 2010 · a9f0ccd · a9f0ccd
1 parent 949dc83
commit a9f0ccd
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/src/dom/layout.js b/src/dom/layout.js
@@ -358,7 +358,7 @@
         if (!Element.Layout.PROPERTIES.include(key)) return;
         var value = this.get(key);
         if (value != null) obj[key] = value;
-      });
+      }, this);
       return obj;
     },
 

diff --git a/test/unit/layout_test.js b/test/unit/layout_test.js
@@ -25,6 +25,7 @@ new Test.Unit.Runner({
       this.assertEqual(normalLayout.get(key), preComputedLayout.get(key), key);
     }, this);
   },
+
   'test layout on absolutely-positioned elements': function() {
     var layout = $('box1').getLayout();
 
@@ -38,6 +39,32 @@ new Test.Unit.Runner({
     this.assertEqual(25, layout.get('left'), 'left');  
   },
 
+  'test toObject method': function(){
+    var layout = $('box1').getLayout();
+
+    // default behavior
+    var object      = layout.toObject(),
+        fullObject  = Element.Layout.PROPERTIES.inject({}, function(obj, key){
+      obj[key] = layout.get(key);
+      return obj;
+    });
+
+    this.assertEnumEqual(Object.keys(object), Element.Layout.PROPERTIES);
+    this.assertEnumEqual(Object.values(object), Object.values(fullObject));
+
+    // with given keys as string
+    object = layout.toObject('width height top left');
+
+    this.assertEnumEqual(Object.keys(object), ['width', 'height', 'top', 'left']);
+    this.assertEnumEqual(Object.values(object), [242, 555, 1020, 25]);
+
+    // with given keys as array of strings
+    object = layout.toObject('width height', 'top', 'left');
+
+    this.assertEnumEqual(Object.keys(object), ['width', 'height', 'top', 'left']);
+    this.assertEnumEqual(Object.values(object), [242, 555, 1020, 25]);
+  },
+
   'test layout on elements with display: none and exact width': function() {
     var layout = $('box2').getLayout();