Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IContractResolver.ResolveContract instead of reflection for generator #321

Closed
RicoSuter opened this issue Feb 20, 2017 · 6 comments
Closed

Use IContractResolver.ResolveContract instead of reflection for generator #321

RicoSuter opened this issue Feb 20, 2017 · 6 comments
Labels
type: enhancement
Milestone
vNext

Comments

@RicoSuter
Copy link
Owner

JsonContract ResolveContract(Type type)
@RicoSuter RicoSuter mentioned this issue Feb 20, 2017
Closed
@RicoSuter RicoSuter added this to the vNext milestone Feb 20, 2017
@markledwich2
Copy link
Contributor

Looking forward to this. I have many discrepancies between the generated schema and my custom contract resolver that i use for serialization. Using the branch solved most of my issues.

@RicoSuter
Copy link
Owner Author

Can you add some unit test to cover your problems?

@markledwich2
Copy link
Contributor

#329

@RicoSuter
Copy link
Owner Author

Can you check the "use-contract-resolver" branch whether it solves your problems? I plan to merge this soon...

https://github.com/NJsonSchema/NJsonSchema/tree/use-contract-resolver

@markledwich2
Copy link
Contributor

I tested this morning. I had one minor issue which i created tests for and fixed. See comments in #345

This was referenced Apr 18, 2017
Open
Closed
@RicoSuter RicoSuter mentioned this issue May 16, 2017
Closed
@RicoSuter
Copy link
Owner Author

v9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
vNext
Development

No branches or pull requests
2 participants
@RicoSuter @markledwich2