Fix for inheritance of abstract properties and ContractResolver that suppresses properties #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markledwich2
commented
Feb 28, 2017
markledwich2
commented
- fixed logic for which properties should be included in schema
- added test for custom contract resolver
- fixed issue with inheritance with an abstract property
- suppress warnings for xml comments in test project
- fixed logic for which properties should be included in schema - fixed issue with inheritance with an abstract property
- added test for string type converter as an example of when contract resolver needs to be used
|
There is plenty of work to go using the parts from the Json.NET contract resolver that overlap with TypeDescription and other classes. I did the minimal I needed to for my project and I'm not confident in #d7a2429, but I think the unit test should be included as serializing an object to a string using the TypeConverter method is standard for Json.NET. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.