add support for Microsemi SmartFusion2 family FPGA #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
And please keep the folder style and code style. Thank you for your contribution. |
2.Add support for GPIO and UART peripherals 3.Add pin and serial device driver support 4.Put pictures in local folder 5.Modify README file
BernardXiong
requested changes
Jul 9, 2020
bsp/smartfusion2/JLinkSettings.ini
Outdated
| @@ -0,0 +1,39 @@ | |||
| [BREAKPOINTS] | |||
| ForceImpTypeAny = 0 | |||
There was a problem hiding this comment.
This file is not necessary.
bsp/smartfusion2/applicatons/main.c
Outdated
| { | ||
| int count = 1; | ||
|
|
||
| rt_pin_attach_irq(SW0_PIN, PIN_IRQ_MODE_RISING, sw0_isr, RT_NULL); |
There was a problem hiding this comment.
Why enable the pin input here? It's only a led blink sample.
| @@ -0,0 +1,434 @@ | |||
| #include <rtthread.h> | |||
There was a problem hiding this comment.
Please provide the copyright information.
There was a problem hiding this comment.
I've finished the revision.
2.Add Kconfig file 3.Delete some unnecessary files and directories
|
你好，可以添加到ci。
…---Original---
From: "guo"<notifications@github.com>
Date: Tue, Nov 10, 2020 15:18 PM
To: "RT-Thread/rt-thread"<rt-thread@noreply.github.com>;
Cc: "whik"<1490789115@qq.com>;"Author"<author@noreply.github.com>;
Subject: Re: [RT-Thread/rt-thread] add support for Microsemi SmartFusion2 family FPGA (#3661)
@Guozhanxin approved this pull request.
测试了下，没有问题。这个需要添加到ci里吗？
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
gcc build failed. |
Guozhanxin
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[添加对Microsemi SmartFusion2 系列 FPGA 芯片的支持 add support for Microsemi SmartFusion2 family FPGA]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up