Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TriCore] Adapt to the TriCore CPU architecture. #4311

Closed
wants to merge 1 commit into from

Conversation

balanceTWK
Copy link
Member

@balanceTWK balanceTWK commented Feb 7, 2021

拉取/合并请求描述:(PR description)

[
描述:
添加对 TASKING 工具链的支持,以便能编译 TC264 BSP。

测试情况:
在 TC264 芯片上测试正常

]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality

src/components.c Outdated
#ifdef RT_USING_SMP
rt_hw_secondary_cpu_up();
#endif
/* invoke system main function */
#if defined(__CC_ARM) || defined(__CLANG_ARM)
extern int $Super$$main(void);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议这部分,以
{

}
的方式把extern相关的声明都框进来。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已更新

@Guozhanxin
Copy link
Member

@snikeguo 你之前应该用过 tricore 吧,可以帮忙看下这个pr吗?

@balanceTWK
Copy link
Member Author

@snikeguo 你之前应该用过 tricore 吧,可以帮忙看下这个pr吗?

TriCore 的 BSP,不在这里,这笔 PR 主要是对 rt-thread 主仓库的修改。

真正的 TriCore BSP,可以关注下 https://github.com/Real-Thread/bsp_tricore 这个仓库。

@balanceTWK balanceTWK closed this Feb 7, 2021
@balanceTWK balanceTWK deleted the master_tc264 branch February 7, 2021 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants