-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add synwit swm341 bsp #6235
add synwit swm341 bsp #6235
Conversation
bsp/swm341/applications/main.c
Outdated
MSH_CMD_EXPORT(spi_w25q_sample, spi w25q sample); | ||
|
||
//#include <dfs_file.h> | ||
//#include <unistd.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些注释的代码还需要是吗,是要在某些宏开启的情况下使用吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,spi外设的测试代码,如果您觉得不需要可以去掉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果留着的话最好有使用说明。要不然开发者也不知道该怎么用。
你好,感谢提交PR, |
#6271 |
您好,整合到一个文件我这边来做,要一起更新一下swm320的lib,您反馈的问题我同步修改,预计本周完成。 |
您好,这个例子中https://www.rt-thread.org/document/site/#/rt-thread-version/rt-thread-standard/programming-manual/device/rtc/rtc?id=rtc-%e8%ae%be%e5%a4%87%e4%bd%bf%e7%94%a8%e7%a4%ba%e4%be%8b设置日期和设置时间分两个函数来设置,是否每次设置都会做UTC处理,导致时间错误? |
你好,这个确实有些问题,但是不影响低层驱动的对接 我们会在v5.0的时候对rtc框架做出调整。 |
一般可以考虑标准time函数来进行日期的设置,只要rtc支持上,time.h里的函数我们都是支持的。 |
好的,我是在测试的时候发现时间设置不对,驱动已经完成,删掉这两个函数,直接用date()设置时间也可以 |
好的 感谢~ |
这个rtc框架好像已经改过很多次了 |
是的 这个rtc框架是最老的一批框架,目前已经完善了。至于您提到的这个问题,实际上更多的是采用time.h的函数来替代。这两个函数是辅助性质的。这两个函数的注意事项,我会放到文档中心中。 |
我再补充一下,使用时间的时候,只要RTC使能了 |
嗯嗯,感谢回复。rtc章节文档可能需要更新一下 |
ok 感谢 那我就先关了
…---Original---
From: ***@***.***>
Date: Sun, Aug 14, 2022 20:08 PM
To: ***@***.***>;
Cc: "Man, Jianting ***@***.***>;"State ***@***.***>;
Subject: Re: [RT-Thread/rt-thread] add synwit swm341 bsp (PR #6235)
您好,整合到一个文件我这边来做,要一起更新一下swm320的lib,您反馈的问题我同步修改,预计本周完成。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
拉取/合并请求描述:(PR description)
[
增加华芯微特SWM341芯片的bsp支持包
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up