🐞 fix(components/drivers): fix cpu timer in multithreading #7222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guozhanxin
reviewed
Apr 12, 2023
| @@ -260,8 +261,6 @@ rt_err_t rt_cputimer_detach(rt_cputimer_t timer) | |||
|
|
|||
| /* parameter check */ | |||
| RT_ASSERT(timer != RT_NULL); | |||
| RT_ASSERT(rt_object_get_type(&timer->parent) == RT_Object_Class_Timer); | |||
There was a problem hiding this comment.
cputimer实际场景是用在us乃至ns级别的场景，把object注册进内核一来用处不大，因为这个object的生命周期就是定时器的时长。二来是因为注册内核和卸载需要频繁拿大小锁，比较耗时，干脆就直接拿掉了
There was a problem hiding this comment.
频繁调用的API，这条意见有效。 init/detach这些应该没有影响。
There was a problem hiding this comment.
rt_object_init, rt_object_detach这些都是用的rt_hw_interrupt_disable作为关锁，在多核上，这个rt_hw_interrupt_disable就是一把大锁来的，很耗时
supperthomas
requested changes
Apr 12, 2023
BernardXiong
approved these changes
Apr 13, 2023
supperthomas
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
原有cpu timer在多线程下存在逻辑错误，造成线程死锁
你的解决方案是什么 (what is your solution)
改用sem
在什么测试环境下测试通过 (what is the test environment)
aarch64 30线程压测几百万次未死锁
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up