Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components] [lwip]重新提交 : ping超时计算bug #7545

Merged
merged 4 commits into from
May 29, 2023

Conversation

Yohozzy
Copy link
Contributor

@Yohozzy Yohozzy commented May 22, 2023

拉取/合并请求描述:(PR description)

函数的输入超时参数的单位是ms, 系统接口无论1.x版本还是2.x, 最终都会将毫秒时间再去转一次tick, 用于rtthread邮件接收超时.

所以此处直接按原值进行转换,不需要加入对RT_TICK_PER_SECOND的转换

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

Yohozzy and others added 4 commits March 2, 2023 17:16
如果函数参数timeout为500,这里会被错误计算成500us,导致超时设置无效卡死
修复ping命令超时小于1s 无法超时退出的bug
函数的输入超时参数的单位是ms, 系统接口无论1.x版本还是2.x, 最终都会将毫秒时间再去转一次tick, 用于邮件接收超时.

所以此处直接按原值进行转换,不需要加入对RT_TICK_PER_SECOND的转换
@supperthomas supperthomas changed the title 重新提交 : ping超时计算bug [components] [lwip]重新提交 : ping超时计算bug May 29, 2023
@mysterywolf mysterywolf merged commit 0cbb665 into RT-Thread:master May 29, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants