Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtdef] support POSIX compatible errno #7954

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

mysterywolf
Copy link
Member

@mysterywolf mysterywolf commented Aug 14, 2023

拉取/合并请求描述:(PR description)

[
related: https://github.com//issues/4791

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

在什么测试环境下测试通过 (what is the test environment)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf mysterywolf force-pushed the errnocode branch 2 times, most recently from 871763c to dad55d1 Compare August 14, 2023 22:50
@mysterywolf mysterywolf force-pushed the errnocode branch 3 times, most recently from 4f4f460 to c67dd02 Compare September 19, 2023 04:53
@mysterywolf mysterywolf marked this pull request as ready for review September 19, 2023 04:53
@mysterywolf mysterywolf force-pushed the errnocode branch 2 times, most recently from 919d7bb to 9db4624 Compare September 19, 2023 05:51
  /home/runner/work/rt-thread/rt-thread/components/libc/compilers/picolibc/syscall.c:13:5: error: conflicting types for 'pico_get_errno'
  int pico_get_errno(void)
      ^
  /opt/LLVMEmbeddedToolchainForArm-16.0.0-Linux-x86_64/bin/../lib/clang-runtimes/arm-none-eabi/armv7em_hard_fpv4_sp_d16/include/sys/errno.h:59:6: note: previous declaration is here
  int *__PICOLIBC_ERRNO_FUNCTION(void);
@Guozhanxin
Copy link
Member

mdk和iar都测过了吗

@mysterywolf
Copy link
Member Author

#3186 此PR没有考虑可维护性 导致后续 #6809 增加新的错误码定义时将出现问题 后续PR将会解决

@mysterywolf mysterywolf merged commit 7732f86 into RT-Thread:master Sep 20, 2023
36 checks passed
@mysterywolf mysterywolf deleted the errnocode branch September 20, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants