Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New eng chapter v4 #6

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

andrewbutterfield
Copy link
Contributor

For review only

eng/fv/approaches.rst Outdated Show resolved Hide resolved
eng/fv/approaches.rst Outdated Show resolved Hide resolved
eng/fv/approaches.rst Outdated Show resolved Hide resolved
eng/fv/approaches.rst Show resolved Hide resolved
eng/fv/methodology.rst Show resolved Hide resolved
eng/fv/refinement.rst Outdated Show resolved Hide resolved
eng/fv/refinement.rst Outdated Show resolved Hide resolved
eng/fv/refinement.rst Outdated Show resolved Hide resolved
eng/fv/tool-setup.rst Outdated Show resolved Hide resolved
* simulatorargs:
These are the command line arguments for the ``sis`` simulator.

``-<bsp> -r s -m <cpus>``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.. these are already supported by rtems-tools, for many simulators. At some point this should be taught how to use the rtems-tools support for running simulators.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I am open to an alternative wording

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be fine to leave as-is for now, and hopefully this can later be improved to rely instead on rtems-tools or some other scripts that are more generic in nature.

@andrewbutterfield
Copy link
Contributor Author

I'll commit the completed minor/typo changes above (into the v4 branch for now). Then I'll address the more complicated ones.

@andrewbutterfield
Copy link
Contributor Author

I've resolved conversations that I feel I have done.

There are still ones open were some feedback would help

@andrewbutterfield
Copy link
Contributor Author

I am going to remove references to sis and mention RTEM tester documentation instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants