Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I have the Filter Results drop-down open and I click off the drop-down on the page background, I would have expected the drop-down to close #1072

Closed
LisaGee opened this issue Sep 5, 2015 · 4 comments

Comments

@LisaGee
Copy link
Contributor

LisaGee commented Sep 5, 2015

Win7, IE11

Steps to Repro:

  1. Go to: https://federalist.18f.gov/preview/18F/college-choice/dev/search/?avg_net_price=0..22000&degree=b&online=1&sort=advantage:desc
  2. Click the Filter drop-down
  3. Click the background of the page, just to the left of the Sort label, for example.
  4. See that the Filter drop-down stays where it is.

Expected Results:
I was expecting it to behave as a normal drop-down, once focus is lost, it closes.

@shawnbot
Copy link
Contributor

shawnbot commented Sep 8, 2015

FYI I played with adding a more sophisticated behavior for touch-enabled browsers that closes the drop-downs when you scroll, but this was a non-starter because the drop-downs actually need to scroll on smaller screens. Clicking (or tapping) outside of an open drop-down should close them when #1209 merges.

@shawnbot
Copy link
Contributor

shawnbot commented Sep 8, 2015

Ready for acceptance on dev.

@shawnbot shawnbot assigned LisaGee and unassigned shawnbot Sep 8, 2015
@LisaGee
Copy link
Contributor Author

LisaGee commented Sep 8, 2015

Working for me on Dev! Chrome.

@ErieMeyer
Copy link
Contributor

🇺🇸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants