Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a Consumer, I can perform a Simple Search with mutliple states #37

Closed
ultrasaurus opened this issue Jun 29, 2015 · 4 comments · Fixed by #337
Closed

As a Consumer, I can perform a Simple Search with mutliple states #37

ultrasaurus opened this issue Jun 29, 2015 · 4 comments · Fixed by #337

Comments

@ultrasaurus
Copy link
Contributor

As a Consumer, I can perform a Simple Search and fill in a state, then add more states, and then see a list of search results

@ultrasaurus
Copy link
Contributor Author

API for this should work now, see: 18F/open-data-maker#76 for the syntax

@shawnbot
Copy link
Contributor

shawnbot commented Aug 7, 2015

@LisaGee I just want to raise a little alarm bell on this one. Implementing @jjoteal's design has proven to be trickier than I'd expected. My preference would be to use a native multi-select, as implied by the region selector in #328 (the drop-down that says "Region(s)"). Any chance you'd be okay with that for the beta?

@LisaGee
Copy link
Contributor

LisaGee commented Aug 7, 2015

Yup. MVP is that a user (on phone or Desktop) can select either multiple States or multiple Regions. Best way we can do that done in the amount of time we have to accomplish that, I’m good with!

@shawnbot
Copy link
Contributor

shawnbot commented Aug 7, 2015

Ugggggh. So multi-selects look completely different, and we have to show a handful of values in order to make sure that people know they can select them. Also, as @meiqimichelle has noted several times, it's a major faux pas to put keyboard help along with these, but I can't think of any other way to do it nicely so here's where I am now:

image

This turns out to be one of those web design things where the native control has serious usability issues (in this case, many people just don't know how to select multiple values), but the alternative is tricky to implement. My question is: Is this good enough for the beta?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants