-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When I search by BOTH a specific Program and by a Degree (Associates or Bachelors), the results should be any school where corresponding CIPxxASSOC >0 or CIPxxBACHL >0 #955
Comments
@ultrasaurus @shawnbot How risky are these changes? |
I think this is addressed by #566 |
moving to accept to confirm that this is, effectively, a dup (the other is not yet ready to accept) |
Assigning Lisa to confirm |
this does not seem to be functioning as expected. |
From Issue #1100 The first school (with default sort threshold earnings) should be Stanford; that one doesn't show up at all, and it cuts instead to Cornell. I have no theory on this one. It also appears predominantly two-year schools that offer a bachelor's degree in that program don't show up. For instance, Pennsylvania College of Technology and Vermont Technical College. Dropping preddeg=2 from the data file yields 147 schools, though, so still kind of inexplicable mismatch with the number of search results. |
Mystery solved: I made these changes in an unmerged branch a while back. I'm going to cherry-pick the relevant commit and push to another branch. |
So I have a fix ready to merge for this, but the result counts I'm getting still don't match up. Compare the bachelors in agriculture searches:
Predominantly two-year schools that offer a bachelor's in the selected program won't show up because our 4-year filter explicitly only includes schools with predominantly bachelors. That might be the source of confusion around the counts in #1100? Reassigning to @LisaGee for triage. |
still filtering by predeg2||3 Need to explore all side effects of behavior. |
Other items to complete before this issue can be resolved:
|
It's working! Tested it out on my mac/chrome and I got the correct filtering when using a combination of program and degree length. Specifically: Search with Any Program/Degree: 21 results Closing--this looks like it is working 🇺🇸 |
This is a more explicit write up of #566
The text was updated successfully, but these errors were encountered: