Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I search by BOTH a specific Program and by a Degree (Associates or Bachelors), the results should be any school where corresponding CIPxxASSOC >0 or CIPxxBACHL >0 #955

Closed
LisaGee opened this issue Sep 1, 2015 · 16 comments

Comments

@LisaGee
Copy link
Contributor

LisaGee commented Sep 1, 2015

This is a more explicit write up of #566

@LisaGee
Copy link
Contributor Author

LisaGee commented Sep 1, 2015

@ultrasaurus @shawnbot How risky are these changes?

@shawnbot
Copy link
Contributor

shawnbot commented Sep 1, 2015

@LisaGee a bit risky. As with #953 and #954, until the API implements these as "developer-friendly" fields, we'll have to maintain a mapping of program names to the numeric codes (xx) in these ones.

@ultrasaurus
Copy link
Contributor

I think this is addressed by #566

@ultrasaurus
Copy link
Contributor

moving to accept to confirm that this is, effectively, a dup (the other is not yet ready to accept)

@ErieMeyer ErieMeyer assigned LisaGee and unassigned ultrasaurus Sep 4, 2015
@ErieMeyer
Copy link
Contributor

Assigning Lisa to confirm

@LisaGee
Copy link
Contributor Author

LisaGee commented Sep 8, 2015

this does not seem to be functioning as expected.

@LisaGee
Copy link
Contributor Author

LisaGee commented Sep 8, 2015

From Issue #1100
Having some difficulty making the program-and-degree search work. Take CIP01 (Agriculture), and bachelor's degree. Two main problems are happening. There should be 237 schools, 243 counting schools with no threshold earnings data, but I only get 186.

The first school (with default sort threshold earnings) should be Stanford; that one doesn't show up at all, and it cuts instead to Cornell. I have no theory on this one.

It also appears predominantly two-year schools that offer a bachelor's degree in that program don't show up. For instance, Pennsylvania College of Technology and Vermont Technical College. Dropping preddeg=2 from the data file yields 147 schools, though, so still kind of inexplicable mismatch with the number of search results.

@shawnbot
Copy link
Contributor

shawnbot commented Sep 8, 2015

Mystery solved: I made these changes in an unmerged branch a while back. I'm going to cherry-pick the relevant commit and push to another branch.

@shawnbot
Copy link
Contributor

shawnbot commented Sep 8, 2015

So I have a fix ready to merge for this, but the result counts I'm getting still don't match up. Compare the bachelors in agriculture searches:

Predominantly two-year schools that offer a bachelor's in the selected program won't show up because our 4-year filter explicitly only includes schools with predominantly bachelors. That might be the source of confusion around the counts in #1100? Reassigning to @LisaGee for triage.

@shawnbot shawnbot assigned LisaGee and unassigned shawnbot Sep 8, 2015
@LisaGee LisaGee removed the Priority 2 label Sep 9, 2015
@LisaGee
Copy link
Contributor Author

LisaGee commented Sep 9, 2015

still filtering by predeg2||3

Need to explore all side effects of behavior.
For example, if a user look for schools with Associates in RI - will get 2
But if look for schools with Associates in RI with Computer Associates (CIP11ASSOC), it would be wierd to see a diff number, like 5. Diff schools appearing, especially new ones would be wierd.

@abisker
Copy link
Contributor

abisker commented Dec 30, 2015

Other items to complete before this issue can be resolved:

@barkimedes
Copy link
Contributor

It's working! Tested it out on my mac/chrome and I got the correct filtering when using a combination of program and degree length.

Specifically:
search with Military Technologies and Applied Sciences

Search with Any Program/Degree: 21 results
Associates: 8 results
Bachelors: 13 results

Closing--this looks like it is working 🇺🇸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants