-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get icons for school page #96
Comments
Love the article! |
@meiqimichelle these are from The Noun Project (except for the "4", which is just a font). Happy to find an alternative for "small." I'll also find icons for the other states (private; rural, suburban; large). Stay tuned! |
Here are the icons for the school page. They are all from The Noun Project, though I tweaked a couple to be a bit more clear. @LisaGee let us know if you approve of these choices and then we can purchase and I can generate SVGs for the custom ones. |
Approved. Although 2 things:
|
@jjoteal Can you send me the links to the noun project files when you're ready? I'll purchase through 18F. |
@LisaGee take a look at these revised options:
|
@meiqimichelle here are links to the approved icons so far:
Please note that the 2- and 4- year icons are just a font (48px bold). Text associated with the icons is 16px bold. |
I think Certificate is fine for the time being. And we’ll let the ED folks weigh in. It may end up needing to just be <2, but we’ll cross that bridge…. I think we’re going to have a hard time with iconography for Public vs Private vs For Profit (the $ made me laugh tho!). I think the important thing is that we don’t want Public to look accessible to everyone and Private to look exclusive. We almost want to make sure that students don’t care if a school is public or private. We kind of only care if a school is not for profit or for-profit. I wonder if the only difference between Private and Public is that one has in-state tuition option? Maybe we do it that way:
What do y’all think? |
@jjoteal I've put in the purchase request for the icons you provided links for. They will be here soon! Any progress on the public/private iconography? @LisaGee , I like your thought on highlighting non-profit versus for-profit instead of public/private, and then highlighting an in-state tuition option. |
I did a bit more looking at definitions on the web and I’m pretty comfortable going not-for-profit, for-profit and in-state/in-district tuition. Let’s do it! Thanks, --Lsia From: Michelle Hertzfeld [mailto:notifications@github.com] @jjotealhttps://github.com/jjoteal I've put in the purchase request for the icons you provided links for. They will be here soon! Any progress on the public/private iconography? @LisaGeehttps://github.com/LisaGee , I like your thought on highlighting non-profit versus for-profit instead of public/private, and then highlighting an in-state tuition option. — |
Ok cool. So I'm understanding correctly, we are:
@LisaGee Can you confirm that I've outlined that correctly? |
Yes please! And you are technically correct in theory, however in practice in-state/in-district tuition is only for Public schools, which are by definition not-for-profit… But overall, yes. |
Love this idea
|
@jjoteal The icons in this comment have been purchased. I put them in PICC > Design > Assets. Back to you for editing the ones you need to :) |
Sorry if I am late to this party... but as Lisa said... "In-State Tuition" and "Out of State Tuition" tags are only for public schools which are different then not-for profit or for-profit. I think it would be great to have three different icons for each of the the types of schools... I have seen plenty of studies showing many students at for profit schools did not know they were attending a for profit school. The more we can help make it easier to distinguish one from the other, the better students will be. |
@saintsoup52 Lisa said "in-state/in-district tuition is only for Public schools, which are by definition not-for-profit" so I was assuming Public schools are equal to Not for Profit. Hence, just the 2 icons: Not-for-Profit and For-Profit. @LisaGee have I misunderstood? |
Thank you for asking... There are three types of schools: We would want a different icon for each of them. |
@LisaGee can you confirm this? Per above, it seemed like the confirmed instructions were:
Is that not the case? Is it what @saintsoup52 is asking for instead? |
@LisaGee assigning this one to you so we can clarification on the above comments. Per the conversation between @saintsoup52 and I, could you tell us what school type icons are needed? Is it: A) Not-for-Profit and For-Profit (with an In-State Tuition indicator) or B) Public, Private Non-Profit, Private For-Profit ? |
Sorry for the delay in response. I didn't realize that has been re-opened as a point of discussion. Let's do the thing I originally specified and that Jess and I agreed on. If we have to come back and revisit, we can (and we may have to, but I'd like to make the argument for doing it the way I suggested). and for the for-profit school icon, I actually do like the homestead with the $ -- I think that paints the picture quite nicely. I was concerned when it was being used to describe Private, but I think it actually works really well for For Profit. Thanks! |
This is definitely not a blocker for going into testing… But there is a BIG difference between private (non-profit) and public schools. A public school is run by the state / local government and usually costs 1/3rd as much as private school run by a non-profit entity. The differences between public and private (non-profit) is one of the most important differentiations that this college choice tool can makes Additionally… Ø private (non-profits) do not charge “in-state” tuition, only public schools charge in-state tuition Ø no one calls a private school a “non-profit” (it is just called private) From: Lisa G. [mailto:notifications@github.com] Let's do the thing I originally specified. If we have to come back and revisit, we can (and we may have to, but I'd like to make the argument for doing it the way I suggested). adn for the for-profit school icon, I actually do like the homestead with the $ -- I think that paints the picture quite nicely. I was concerned when it was being used to describe Private, but I think it actually works really well for For Profit. Thanks! — |
@meiqimichelle here are the links to the remaining icons for purchasing: https://thenounproject.com/search/?q=government%20building&i=143674 https://thenounproject.com/search/?q=price+tag&i=78865 Please download and post to the PICC folder on Google Drive when purchased, as I will have to edit them before we implement. Thanks! |
@jjoteal Thanks! I've put in the request for purchase and will keep you updated. |
Sigh. I just sent @LisaGee an email for approval. That is still required in our new purchase process and I didn't know that. Once I forward that to the right place, they'll go ahead and buy. |
The icons should be in our shared assets folder @jjoteal :D |
Thanks, Michelle! Per Lisa's most recent comment, it sounds like we are going with the homestead with the $ for For-Profit, so I'll just work from the Not-for-Profit icon and add a $ sign. Feel free to use the Not-for-Profit as-is in implementation (https://thenounproject.com/search/?q=government%20building&i=143674) and then I'll have the For-Profit icon your way this afternoon. |
@meiqimichelle For-Profit icon is now in PICC in the shared assets folder. File name is for-profit.svg |
I think the purchaser needs to confirm that these icons were appropriately acquired and they can accept the story. I think that's @meiqimichelle |
This task is complete. We have the icons. |
We need to acquire the icons on the individual school pages:
![4eb5b16a-2556-11e5-85c9-fffffae3470a](https://cloud.githubusercontent.com/assets/4827522/8599675/c01a57b4-2616-11e5-9d7a-c60a3bdd9a8a.png)
@jjoteal Where are these from? Also, I think the one on the right is suuuuper similar to an old 'groups' icon from Facebook (interesting Medium article on this here ). I recommend using a different one so that we're not unintentionally brand-linking to FB (or, use something closer to their newer version).
This is in response to a task in #44.
The text was updated successfully, but these errors were encountered: