Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase contrast for the school page sidebar. #1431

Merged
merged 2 commits into from Feb 5, 2016

Conversation

stevenbuccini
Copy link
Contributor

Fixes #1419.

I mucked around with the CSS a little more than I'd like. On my Macbook Air, the previous CSS eliminated the left/right padding, which didn't look good. The downside to adding the padding back is that on medium screensizes the text within the button breaks onto two lines easily.

I'd like some feedback on whether or not this padding change is necessary. Here's how it looks right now on my Macbook Air, browser full-paged:
screen shot 2016-01-16 at 10 59 46 pm

@shawnbot
Copy link
Contributor

shawnbot commented Feb 3, 2016

The only thing that bugs me about this is the text wrapping of the first button. I would prefer that it read:

Types of
Financial Aid

@nguyenist, what do you think? This would require a bit more effort to get it working correctly on different screen sizes; for instance, it might not need to wrap on mobile. cc @abisker @barkimedes for visibility

@shawnbot
Copy link
Contributor

shawnbot commented Feb 3, 2016

And let me just say, once again: thank you for putting your time into this, @stevenbuccini! We're going to try to get this into our next release.

@shawnbot
Copy link
Contributor

shawnbot commented Feb 5, 2016

@jjoteal has signed off on this in #1419. Merging.

Thanks again, @stevenbuccini! 🚀

shawnbot added a commit that referenced this pull request Feb 5, 2016
Increase contrast for the school page sidebar.
@shawnbot shawnbot merged commit f1150f9 into RTICWDT:dev Feb 5, 2016
@nguyenist-zz
Copy link

@shawnbot I agree it would look cleaner! *Also coming in with fresh eyes on the project, but wouldn't spend too much time on this unless users are missing the button / having difficulty with it because of the labeled text on the button.
image

And yes, you're right, it seems like no wrap needed on mobile! (at least on an iPhone 6S Plus):
image

@stevenbuccini
Copy link
Contributor Author

@shawnbot @nguyenist My intuition says that if you just put a   in between "of" and "financial," CSS will do the right thing® when it comes to breaking the text the way you'd like. I'll test that theory later today.

@stevenbuccini stevenbuccini deleted the increase_contrast branch February 8, 2016 18:37
@stevenbuccini stevenbuccini restored the increase_contrast branch February 8, 2016 18:38
@shawnbot
Copy link
Contributor

shawnbot commented Feb 8, 2016

Yeah, that might do it @stevenbuccini. Although I think we'd want Types of Financial Aid and Calculate Your Aid to suggest keeping the right phrases together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants