Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 1 #5

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Fix issue 1 #5

merged 2 commits into from
Jun 1, 2023

Conversation

M0stafaRady
Copy link
Contributor

  • Add test to test reading from gpio configurations values
  • Add RTL change to fix issue 1

@M0stafaRady M0stafaRady mentioned this pull request May 30, 2023
Closed
RTimothyEdwards
RTimothyEdwards approved these changes Jun 1, 2023
View reviewed changes
Copy link
Owner

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, looks good. The solution for ORing bits of the array is horribly ugly, but I guess that's what works.

@RTimothyEdwards RTimothyEdwards merged commit 834a3b3 into RTimothyEdwards:main Jun 1, 2023
@M0stafaRady M0stafaRady deleted the fix_issue_1 branch June 1, 2023 08:22
@kareefardi kareefardi mentioned this pull request Jun 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RTimothyEdwards RTimothyEdwards RTimothyEdwards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select out of bounds on signal gpio_dat_o[*]
2 participants
@M0stafaRady @RTimothyEdwards