Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework configure script to be more standard #127

Closed
wants to merge 8 commits into from

Conversation

mithro
Copy link
Contributor

@mithro mithro commented Jun 13, 2021

  • Use --prefix to specify where in the file system to install the PDKs too.

  • Use DESTDIR with make install to create a distribution that can be extracted to --prefix using a package management / system administration system.

  • Continue to support old makefile targets as aliases.

  • Add a autogen.sh script.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
 * Use `--prefix` to specify where in the file system to install the
   PDKs too.

 * Use `DESTDIR` with `make install` to create a distribution that can
   be extracted to `--prefix` using a package management / system
   administration system.

 * Continue to support old makefile targets as aliases.

 * Add a `autogen.sh` script.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
Fixes RTimothyEdwards#141.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
@mithro
Copy link
Contributor Author

mithro commented Jun 13, 2021

I'm unsure how to continue to support the old --with-sky130-local-path / --with-sky130-dist-path values....

Otherwise it is quite hard to tell when something is going into the
staging directory or when the paths are wrong and it is installing to
the wrong place.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
@mithro
Copy link
Contributor Author

mithro commented Aug 8, 2021

Friendly poke?

Copy link
Owner

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. There are a couple of minor errors but I will patch them up by hand.

@RTimothyEdwards
Copy link
Owner

Pulled, fixed merge conflicts, corrected a few typos, and committed.

Note that for reasons of backwards compatibility, I kept the directory name "pdk", not "pdks". Also, I made the default prefix to be "/usr", so that by default open_pdks installs into "/usr/share/pdk", not "/usr/local/share/pdk".

Update was made to the repository at opencircuitdesign.com; the changes will update on github at 3:00am EDT.

@mithro
Copy link
Contributor Author

mithro commented Aug 20, 2021

Pulled, fixed merge conflicts, corrected a few typos, and committed.

Note that for reasons of backwards compatibility, I kept the directory name "pdk", not "pdks". Also, I made the default prefix to be "/usr", so that by default open_pdks installs into "/usr/share/pdk", not "/usr/local/share/pdk".

That violates the traditional Linux standard which is;

  • Installs from source should go to /usr/local
  • Installs from packages should go to /usr

@RTimothyEdwards
Copy link
Owner

Oh, is that a standard? If so, it has historically been badly conceived and improperly executed, but sure, whatever.

@RTimothyEdwards
Copy link
Owner

Fixed.

@mithro
Copy link
Contributor Author

mithro commented Aug 20, 2021

@mithro
Copy link
Contributor Author

mithro commented Aug 20, 2021

@mithro
Copy link
Contributor Author

mithro commented Aug 20, 2021

@mithro
Copy link
Contributor Author

mithro commented Aug 20, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants