Skip to content
This repository has been archived by the owner on Jan 13, 2021. It is now read-only.

api/v2: Add hostname to systems check HTTP response headers #421 #423

Merged
merged 1 commit into from
Dec 22, 2019

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented Dec 22, 2019

👷 Purpose

Fixes: #421

🚀 Changes

To add response header (X-API-Host: hostname)to request router /v2/systems/check

⚠️ Breaking Changes

If the API server does not set a hostname, response cannot help returning 5XX status code.

@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #423 into master will increase coverage by 0.37%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   52.69%   53.06%   +0.37%     
==========================================
  Files          43       43              
  Lines        4151     4156       +5     
==========================================
+ Hits         2187     2205      +18     
+ Misses       1476     1464      -12     
+ Partials      488      487       -1
Impacted Files Coverage Δ
api/v2/routes_utils.go 34.22% <40%> (+0.2%) ⬆️
queue/ipfs_cluster.go 69.48% <0%> (+16.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3ccd7...ab4e520. Read the comment docs.

Copy link
Contributor

@xiegeo xiegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, it looks great to me. @bonedaddy will review and merge it. Please be patient because of the holidays.

Copy link
Contributor

@bonedaddy bonedaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and tyvm for doing this.

@bonedaddy bonedaddy merged commit 48f2678 into RTradeLtd:master Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hostname To Systems Check HTTP Response Headers
3 participants