-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Tetris Colors #3
Conversation
var s = { size: 3, blocks: [0x06C0, 0x8C40, 0x6C00, 0x4620], color: 'teal' }; | ||
var t = { size: 3, blocks: [0x0E40, 0x4C40, 0x4E00, 0x4640], color: 'coral' }; | ||
var z = { size: 3, blocks: [0x0C60, 0x4C80, 0xC600, 0x2640], color: 'olive' }; | ||
var i = { size: 4, blocks: [0x0F00, 0x2222, 0x00F0, 0x4444], color: 'blue' }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that i
and t
have the same color, maybe we can have different colors.
Same for j
and z
Requesting changesThanks for making that suggestion on my change. In my excitement to ship more stuff, I must have gotten distracted while picking colors. 馃槵 I'm making a change to this branch to fix my mistake. Not all the pull request reviews you perform in the future will decide the color of the blocks in our Tetris game. 馃槃 Although you may want to leave short comments like: 馃憤, 馃憥馃徑, awesome!, or no; these don't give the author much detail. Provide comments like the following to enable the author of the pull request to respond:
Step 5: Practice reviewsWhile you were reading this, I made your suggested changes. If you could approve my pull request, that would be awesome! 鈱笍 Activity: Give another pull request review
Return to this pull request for my next comment
|
Step 8: Don't just review, suggest!Now that you have explored the different ways you can review a pull request it is time to learn how to use the suggest changes functionality. This feature, enables you to recommend a change to a pull request that the author can commit with the push of a button! 鈱笍 Activity: Create a pull request
Click here to start the pull request |
Using
request changes
on a pull requestThanks again for all your help on that last pull request. With our powers combined, anything is possible! This next change might introduce some new changes that aren't going to look great.
Sometimes, the author might identify that something isn't working. They might need a helping hand 馃憢 to solve the problem. In other instances, it might only work in their environment. When reviewing a pull request, look at and test the code to pinpoint any bugs or unexpected behavior.
Writing a review
Review the
diff
Reviewing the
diff
, the comparison of the proposed code, in the context of the whole project. Could it introduce performance problems, or security vulnerabilities? Try to predict unintended consequences that this change could cause.Try it out
For most things, actually trying out the proposed change is a good idea. This makes it a lot easier to tell if the actual change matches the intention. You can do this by:
When summarizing your review, let the author know if you completed any of these tests.
Empathy and Constructive Feedback
The goal of providing feedback on a pull request is to ensure that the best possible change is being added. Sometimes, a change isn't addressing the problem in the best possible way. It's the reviewer's responsibility to provide meaningful and constructive feedback.
Requesting Changes 101
Before you submit your review, your line comments are pending and only visible to you. You can edit pending comments anytime before you submit your review. To cancel a pending review and its pending comments, scroll down to the end of the page in the Conversation tab. Then click Cancel review.
Step 4: Leave a review that asks for changes
If you could check out this code for me and tell me what is wrong, that would be fantastic.
鈱笍 Activity: Requesting changes
Return to this pull request for my next comment