dataset.num_overlap_item(user) is already set in line 428(384) of dat…

…aset.py for pad, no necessary to add 1.
RUCAIBox · Jun 16, 2023 · 2c7470d · 2c7470d
1 parent 1758db4
commit 2c7470d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -16,3 +16,4 @@ saved/
 *.egg-info/
 docs/build/
 wandb/*
+.DS_Store
diff --git a/recbole_cdr/sampler/crossdomain_sampler.py b/recbole_cdr/sampler/crossdomain_sampler.py
@@ -195,8 +195,8 @@ def __init__(self, phases, dataset, built_datasets, distribution='uniform'):
         self.uid_field = self.dataset.uid_field
         self.iid_field = self.dataset.iid_field
 
-        self.overlapped_item_num = dataset.num_overlap_item + 1  # for [pad]
-        self.overlapped_user_num = dataset.num_overlap_user + 1
+        self.overlapped_item_num = dataset.num_overlap_item
+        self.overlapped_user_num = dataset.num_overlap_user
 
         self.source_only_item_num = dataset.num_source_only_item
         self.source_only_user_num = dataset.num_source_only_user