Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Support fixed-size matrices #113

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

yaqwsx
Copy link
Contributor

@yaqwsx yaqwsx commented Oct 19, 2022

This PR should add support for fixed-size matrices (#112). At the moment, the fix wasn't properly tested.

I am not familiar with carma's codebase, so if I missed something, please, let me know, and I will try to address it.

include/carma_bits/converters.h Show resolved Hide resolved
include/carma_bits/typecheck.h Show resolved Hide resolved
@RUrlus RUrlus marked this pull request as ready for review November 9, 2022 15:42
@RUrlus
Copy link
Owner

RUrlus commented Nov 9, 2022

Thanks @yaqwsx. Sorry for the late response. Looks good to me.
fixes #113

@RUrlus RUrlus merged commit efbe052 into RUrlus:stable Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants