Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Update checker label doesn't update when user opts to view latest update #19

Closed
RyanWalpole opened this issue Mar 8, 2022 · 2 comments
Assignees
Labels
type: bug A bug or issue that causes the application to not function as intended.

Comments

@RyanWalpole
Copy link
Collaborator

Describe the Issue
When an update is available and the user opts to view the latest update, the default browser opens the page for the latest release - however the "Check for updates" label remains on "Checking for updates...".

Steps to Replicate
Steps to reproduce the behavior:

  1. Run v220202 or v220301
  2. Click "Check for Updates"
  3. Opt to view the latest release
  4. Return to the application and observe the "Checking for Updates..." text.

Expected behavior
The expected behaviour would be for the label to state "Updates Available" or something along those lines to indicate that the application has completed checking for updates. Similarly to how when there isn't an available update, the text changes to "Up to date! Check again?"

Screenshots
image

Environment:

  • Windows Version: Windows 11
  • Mod Manager Version: 220202, 220301
@RyanWalpole RyanWalpole added the status: needs triage Requires assessment to determine severity, impact and to collect more data on the issue. label Mar 8, 2022
@RyanWalpole RyanWalpole added this to To do in Dev: SDVMM v220303 Mar 8, 2022
@RWELabs RWELabs added the type: bug A bug or issue that causes the application to not function as intended. label Mar 8, 2022
@RyanWalpole
Copy link
Collaborator Author

Add following adjustment to code:

UpdateCheckLabel.Enabled = true;
UpdateCheckLabel.Text = "Updates available.";

To both the DialogResult = yes (after launching the tab) and also if the DialogResult != yes.

@RyanWalpole RyanWalpole moved this from To do to In progress in Dev: SDVMM v220303 Mar 9, 2022
RWELabs added a commit that referenced this issue Mar 9, 2022
Implement change for fix #19 where the update label doesn't change text when an update is found.

Co-Authored-By: Ryan Walpole <69621127+RyanWalpole@users.noreply.github.com>
@RWELabs RWELabs removed the status: needs triage Requires assessment to determine severity, impact and to collect more data on the issue. label Mar 9, 2022
@RyanWalpole RyanWalpole added this to the v220303_Stable milestone Mar 9, 2022
@RyanWalpole RyanWalpole moved this from In progress to Done in Dev: SDVMM v220303 Mar 10, 2022
@RyanWalpole RyanWalpole moved this from Done to In Testing (release-alpha) in Dev: SDVMM v220303 Mar 10, 2022
@RyanWalpole RyanWalpole moved this from In Testing (release-alpha) to Done in Dev: SDVMM v220303 Mar 10, 2022
@RyanWalpole
Copy link
Collaborator Author

Testing Report
Issue has been resolved in current alpha build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A bug or issue that causes the application to not function as intended.
Projects
Development

No branches or pull requests

2 participants