Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only possible to embedded MediaItem entities in Rich Text fragments #93

Closed
willprice76 opened this issue Apr 10, 2018 · 2 comments
Closed

Only possible to embedded MediaItem entities in Rich Text fragments #93

willprice76 opened this issue Apr 10, 2018 · 2 comments
Labels
enhancement PR
Milestone
v2.2

Comments

@willprice76
Copy link
Contributor

The ability to embed entities in Rich Text fragments is great, and can simply be made more generic to allow more than just images. See RWS/dxa-content-management#13 for the corresponding issue to change the publishing process. Necessary is that the RichTextDataConverter can handle the case where the embedded entity is not a MediaItem, and instead tries to map it to an AbstractEntityModel.

This is the relevant part of the code which needs to be altered.

https://github.com/sdl/dxa-web-application-java/blob/58a4fdebafc192b9a87570c684bd97d9091fdc5f/dxa-framework/dxa-tridion-provider/src/main/java/com/sdl/dxa/tridion/mapping/converter/RichTextDataConverter.java#L39
This was referenced Apr 10, 2018
Open
Closed
willprice76 pushed a commit to willprice76/dxa-web-application-java that referenced this issue Apr 10, 2018
@RaimondKempees
Fixed issue RWS#93
d01415c
willprice76 added a commit to willprice76/dxa-web-application-java that referenced this issue Apr 10, 2018
@willprice76
Issue RWS#93 - enable any entity type (not only MediaItem) to be embe…
fc5594b 
…dded in RTF fragment
@willprice76 willprice76 mentioned this issue Apr 13, 2018
Closed
@rpannekoek rpannekoek added this to the v2.2 milestone Dec 17, 2018
@rpannekoek
Copy link
Contributor

Internal ID (for tracking purposes): CRQ-12781

@rpannekoek rpannekoek added the PR label Dec 18, 2018
@rpannekoek
Copy link
Contributor

Incorporated in DXA 2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement PR
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
2 participants
@willprice76 @rpannekoek