Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Division by zero error in valve models when using BaseClasses.PartialTwoWayValveKv #1018

Closed
LauraMaier opened this issue Oct 8, 2020 · 1 comment · Fixed by #1059
Closed
Assignees
Labels

Comments

@LauraMaier
Copy link
Contributor

LauraMaier commented Oct 8, 2020

1. The Problem/Bug

When using AixLib.Fluid.Actuators.BaseClasses.PartialTwoWayValveKv or AixLib.Fluid.Actuators.BaseClasses.PartialTwoWayValve as base class within the valve models (e.g. if you don´t use a specific valve data set), model errors occur. The following valve models are affected (among maybe others):

  • AixLib.Fluid.Actuators.Valves.TwoWayEqualPercentage

  • AixLib.Fluid.Actuators.Valves.TwoWayLinear

  • AixLib.Fluid.Actuators.Valves.TwoWayPolynomial

  • AixLib.Fluid.Actuators.Valves.TwoWayPressureIndependent

  • AixLib.Fluid.Actuators.Valves.TwoWayQuickOpening

  • AixLib.Fluid.Actuators.Valves.TwoWayTable

2. How will I fix the problem?

In the IBPSA library a minimum value of 0.1*leakage rate was given for phi. This way, division by zero is prevented.

@LauraMaier LauraMaier self-assigned this Oct 8, 2020
@LauraMaier LauraMaier added the bug label Oct 8, 2020
@PMehrfeld
Copy link
Member

@LauraMaier : So it is related to this issue here? And we only need a next IBPSA merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants