Rebuilding the reversible HP model based on a new general partial model for reversible HPs and chillers #715
Comments
The package structure was created.
JulianMatthes
changed the title
JulianMatthes
changed the title
…al 'just cooling' operation mode. Simulation results match with the current heat pump model. #715
JulianMatthes
changed the title
…hermalMachine.mo. Furthermore building of the new reversible heat pump model based on the partial models. Also, the belonging new example for the reversible heat pump was built and tested. #715
…rtial models as the new chiller model. #715
Furthermore changed heat pump Systems/HeatPumpSystems/HeatPumpSystem.mo because of this issue. Next step is to also adapt the FastHVAC models.
…Components/HeatGenerators/HeatPump.mo for issue #715
… old models from the first development steps in this issue. #715
… to hand down the heat pump characteristics chosen on the upper model level to the used heat pump model. #715
…HeatPump/PerformanceData.mo to improve the handling and use of the thermal machine model. Furthermore fixed consideration of the icing factor in Chillers/BaseClasses/PerformanceData.mo. #715
…erefore corrected examples in FastHVAC and Fluid library. #715
…ator and condenser parameters. #715
|
@JulianMatthes please have a look at #769 and check if everything still works or if their are necessary changes. If no changes needed, can we merge this into development? |
|
@DaJansenGit #769 is based on the current dev and this branch was already 2 months behind it. So changes had to be made merging it into this branch. They can be found in the belonging PR #724 |
|
@DaJansenGit Can you have a look at the failed check in PR #724 ? As I see it, the branch will be ready to merge after merging the last changes in the development into this branch, if the tests pass. Maybe you have got a clue, what went wrong. I am no expert on CI... |
|
@KremerMartin this seems to be due to missing regression test results. We have the same problem with #774. In the next days I will try to update the regression test files. |
|
closed by merge of #724 |
What is the problem?
A new reversible chiller model based on the structure of the reversible heat pump model is required. To optimize its usability a new partial model for thermal machines (e.g. heat pumps, chillers) shall be developed. Furthermore the previous reversible heat pump model and the new reversible chiller model are to be extended from this partial model. Also, the improvements in applicability include variable naming.
For that reason the variable naming when changing the operation mode shall fit to its belonging function (evaporator or condenser).
How do we want to solve it?
A new partial model shall be developed. The heat pump and the chiller model extend from this partial model placed in the base class of the Fluid library. A query is defined as to whether reversible operation is possible. In addition, the elements on the condenser and evaporator side are named and connected starting from the main operating mode (heating or cooling).
Finally belonging FastHVAC models are to be adapted analogously.
The text was updated successfully, but these errors were encountered: