Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1368 pump polynomial based om #1374

Merged
merged 3 commits into from Oct 13, 2022
Merged

Issue1368 pump polynomial based om #1374

merged 3 commits into from Oct 13, 2022

Conversation

KremerMartin
Copy link
Contributor

Closes #1368.

This PR fixes the problems with OpenModelica for the polynomial-based pump models.

@martinkremer
[skip-ci] Change extrapolation in look-up table to 'Hold last point';…
463c3f1 
… changed critical damping to order 1

For #1368
@martinkremer
[skip-ci] Delete StateGraphs as they lead to problems with OpenModelica.
1ecabae 
Also they are incorrect, since the head is delayed by 60 seconds but the on-Signal of the pump is not delayed.

For #1368
@KremerMartin KremerMartin self-assigned this Oct 13, 2022
@KremerMartin KremerMartin added the OpenModelica Related to usage in OM label Oct 13, 2022
@KremerMartin KremerMartin added this to the Hackday 10.2022 milestone Oct 13, 2022
larissakuehn
larissakuehn approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@larissakuehn larissakuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the examples and it looks fine, thank's for your work!

@KremerMartin KremerMartin merged commit 103434f into openModelicaProject Oct 13, 2022
@KremerMartin KremerMartin deleted the issue1368_PumpPolynomialBasedOM branch October 13, 2022 14:44
@KremerMartin KremerMartin mentioned this pull request Oct 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larissakuehn larissakuehn larissakuehn approved these changes

Assignees

@KremerMartin KremerMartin

Labels
OpenModelica Related to usage in OM
Projects
None yet
Milestone
Hackday 10.2022
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KremerMartin @larissakuehn @martinkremer