Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor units model and add example #107

Closed
tstorek opened this issue Jan 15, 2022 · 1 comment
Closed

Refactor units model and add example #107

tstorek opened this issue Jan 15, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@tstorek
Copy link
Collaborator

tstorek commented Jan 15, 2022

Describe the bug
According to the ngsiv2 specification metadata of attributes are not supposed to contain nested data objects. Hence, the current implementation of units does not align with this specification.

Solution
We need to refactor the unit model according to specs. Hence, when we have type "unit", we will only evaluate the values but not explicitly set the types for each value. This might even simplify the unit pattern

@tstorek tstorek added the bug Something isn't working label Jan 15, 2022
@tstorek tstorek self-assigned this Jan 15, 2022
@github-actions
Copy link

Branch 107-Refactor-units-model-and-add-example created!

tstorek added a commit that referenced this issue Jan 16, 2022
tstorek added a commit that referenced this issue Jan 16, 2022
tstorek added a commit that referenced this issue Jan 16, 2022
tstorek added a commit that referenced this issue Jan 17, 2022
chore: edit changelog 

for #107
tstorek added a commit that referenced this issue Jan 17, 2022
…d-example

fix: 107-Refactor-units-model-and-add-example [#107](#107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant