Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change does_entity_exists create error message if entity does not exist #167

Closed
windrad6 opened this issue Sep 23, 2022 · 2 comments
Closed

Change does_entity_exists create error message if entity does not exist #167

windrad6 opened this issue Sep 23, 2022 · 2 comments
Assignees
@tstorek
Labels
bug Something isn't working

Comments

@windrad6
Copy link
Contributor

The does_entity_exists function is directly calling the get_entity function. If entity does not exists this function will fail and create an error message. The expected behavior would not be an error message when probing for existing element.
@windrad6 windrad6 added the bug Something isn't working label Sep 23, 2022
@tstorek tstorek self-assigned this Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Branch 167-Change-does_entity_exists-create-error-message-if-entity-does-not-exist created!

@tstorek
Copy link
Collaborator

tstorek commented Dec 7, 2022 •
edited

@windrad6 I checked on this. The function's response is correct, but the log is misleading if the entity does not exist. Probably, it is easier and cleaner to write an extra request for this, right?

Alternatively, it would possible to temporarily change the log level for this call but that's gonna be ugly I guess.

tstorek added a commit that referenced this issue Dec 7, 2022
@tstorek
fix: misleading log for does_entity_exist
74974f4 
For #167
@tstorek tstorek mentioned this issue Dec 7, 2022
Merged
tstorek added a commit that referenced this issue Dec 7, 2022
@tstorek
refactor(ngsi_v2.ContextBrokerClient)!: misleading log for does_entit…
a09e20e 
…y_exist

BREAKING CHANGE: Renaming of `does_entity_exists` to `does_entity_exist`

For #167
tstorek added a commit that referenced this issue Dec 7, 2022
@tstorek
refactor(ngsi_v2.ContextBrokerClient)!: misleading log for does_entit…
301fd4c 
…y_exist

BREAKING CHANGE: Renaming of `does_entity_exists` to `does_entity_exist`

For #167
@github-actions github-actions bot closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstorek tstorek

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tstorek @windrad6