Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete device update #74

Closed
RedingJeff opened this issue Nov 18, 2021 · 1 comment · Fixed by #75
Closed

Complete device update #74

RedingJeff opened this issue Nov 18, 2021 · 1 comment · Fixed by #75
Assignees
Labels
feature request Request a potential feature

Comments

@RedingJeff
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When using update_device to push made changes in a device to Fiware, the device in the iota client is correctly updated, but the corresponding entity is not. Here only new attributes are added, but removed attributes are not deleted and changed values are not updated. Further changed device_settings as transport are not taken over to Fiware.

Currently the only reliable way to take over all changes is to delete the device and the corresponding entity and to repost them.

Describe the solution you'd like
To make the interaction here much cleaner, I propose the method patch_device (linked to Issue 21), that takes a device model object and makes all the needed updates for the user to take over all made changes to Fiware. It will internaly delete and repost the device only if the main device settings (endpoint,..) were changed, else it will use the methods update_device and patch_entity to update the stats.

This issue will also provide the tests to ensure the correctness of the functions (and a test for update_device, that is still missing). Further a few simple quality of live methods as does_device_exist are introduced.

@RedingJeff RedingJeff added the feature request Request a potential feature label Nov 18, 2021
@RedingJeff RedingJeff self-assigned this Nov 18, 2021
@github-actions
Copy link

Branch 74-Complete-device-update created!

@RedingJeff RedingJeff linked a pull request Nov 18, 2021 that will close this issue
tstorek added a commit that referenced this issue Nov 18, 2021
format change

for #74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request a potential feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant