222 integration of ngsi ld endpoints #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addes reference to readme
edit authors and alumni
adjusted copyright year
# Conflicts: # filip/models/base.py
Add authorization field to fiware-header
216 release v0 3 0
# Conflicts: # README.md
…ible-with-Pydantic-v2 fix: updated regex to pattern
…hub.com/RWTH-EBC/FiLiP into 221-ngsi-ld-migrate-V2-datamodels-in-ld
Signed-off-by: iripiri <iris.m.koester@gmail.com>
…1' into 222-Integration-of-NGSI-LD-endpoints
Signed-off-by: iripiri <iris.m.koester@gmail.com>
…mentation Signed-off-by: iripiri <iris.m.koester@gmail.com>
…hub.com/RWTH-EBC/FiLiP into 221-ngsi-ld-migrate-V2-datamodels-in-ld
Signed-off-by: iripiri <iris.m.koester@gmail.com>
…hub.com/RWTH-EBC/FiLiP into 221-ngsi-ld-migrate-V2-datamodels-in-ld
Signed-off-by: iripiri <iris.m.koester@gmail.com>
Signed-off-by: iripiri <iris.m.koester@gmail.com>
…1' into 222-Integration-of-NGSI-LD-endpoints
Endpoints (implemented & tested):Entities
Batch operations
Subscriptions
|
djs0109
commented
Jun 12, 2024
| csf: Optional[str] = None, | ||
| limit: Optional[PositiveInt] = 100, | ||
| response_format: Optional[Union[AttrsFormat, str]] = AttrsFormat.NORMALIZED.value, | ||
| ) -> Union[Dict[str, Any]]: |
There was a problem hiding this comment.
@iripiri The type hint should be adjusted because normally, a list of ContextLDEntity will be returned.
djs0109
commented
Jun 12, 2024
| """ | ||
| Cleanup entities from test server | ||
| """ | ||
| entity_test_types = ["MyType", "room"] |
There was a problem hiding this comment.
Why should the cleanup limited to these types of entities?
| CB_URL = "http://137.226.248.200:1027" | ||
| self.cb_client = ContextBrokerLDClient(url=CB_URL, | ||
| fiware_header=self.fiware_header) | ||
|
|
There was a problem hiding this comment.
Add a cleanup step here will increase the robustness of the tests
| entity_test_types = ["MyType", "room"] | ||
|
|
||
| fiware_header = FiwareLDHeader() | ||
| with ContextBrokerLDClient(fiware_header=fiware_header) as client: |
There was a problem hiding this comment.
Is it possible to implement a clean up function for LD context broker? It can be placed under filip.utils.cleanup
| self.cb_client.post_entity(entity=self.entity_2) | ||
| entity_list = self.cb_client.get_entity_list() | ||
| self.assertEqual(len(entity_list), 2) | ||
| self.assertEqual(entity_list[0].id, self.entity.id) |
There was a problem hiding this comment.
We can actually not ensure that the order of the entities is not changing.
| self.assertEqual(response.status_code, 404) | ||
| self.assertEqual(response.json()["title"], "Entity Not Found") | ||
|
|
||
| """Test2""" |
There was a problem hiding this comment.
This scenario is different as the the description above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #222