Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annex model calculation #130

Closed
PRemmen opened this issue Feb 15, 2016 · 12 comments
Closed

Annex model calculation #130

PRemmen opened this issue Feb 15, 2016 · 12 comments
Assignees
Labels
Milestone

Comments

@PRemmen
Copy link
Member

PRemmen commented Feb 15, 2016

integrate parameter calculation of annex models

@PRemmen PRemmen added the Logic label Feb 15, 2016
@PRemmen PRemmen added this to the v0.3.0 milestone Feb 15, 2016
PRemmen pushed a commit that referenced this issue Apr 29, 2016
PRemmen pushed a commit that referenced this issue May 10, 2016
PRemmen pushed a commit that referenced this issue May 12, 2016
@PRemmen PRemmen mentioned this issue May 12, 2016
2 tasks
@PRemmen
Copy link
Member Author

PRemmen commented May 12, 2016

Following things to do:

  • Write Template for model export
  • Distinguish between AixLib and Annex60 on Building class level (needed for the correct output of orientations, tilts and weightfactors)
  • check if all parameters are calculated, that are needed for the export (especially coefficient for heat transfer)
  • revise unit tests for sum_building_elements() (this used to be combine_building_elements)
  • revise unit test for calc_chain_matrix
  • revise unit tests where "vdi" or "ebc" is used as calculation method
  • revise documentation where necessary (e.g. new attributes thermal zone)
  • revise weightfactorscalculation on TZ (one weighfactor for every BE)
  • revise the sum of the weightfactors on Building level
  • anything else @MichaMans

@PRemmen
Copy link
Member Author

PRemmen commented May 12, 2016

@mlauster in the annex models there is a attribute for every building element called "alphaExt - coefficient of heat transfer of XYZ" is this the convective coefficient of heat transfer? If so: should this maybe added in the documentation of the model?

@mlauster
Copy link
Contributor

Perfect, I was starting working on that issue in this minute! :-)

@PRemmen
Copy link
Member Author

PRemmen commented May 12, 2016

One more thing :)

  • Move AixLib specific calculations to a module in Simulation package (and the same for annex)

@mlauster
Copy link
Contributor

@PRemmen, thanks for the remark, I changed the comment for alpha... to "Convective coefficient of heat transfer"

@mlauster
Copy link
Contributor

I will take care of the templates tomorrow or on Saturday.

@MichaMans
Copy link
Contributor

MichaMans commented May 13, 2016

I'll take care of the change of the weighfactors calculation. As discussed with @PRemmen. Afterwards we can implement and adopt it for the annex calculation. I'll add the points to the ToDo.

MichaMans added a commit that referenced this issue May 13, 2016
MichaMans added a commit that referenced this issue May 13, 2016
@mlauster
Copy link
Contributor

mlauster commented May 14, 2016

Question:

  • Are tilt, latitude and azimute defined in deg or rad in TEASER? The Annex models have deg as display unit, but use rad internally. SO for the Annex models, we need rad.
  • Do we have a list with the area of all exterior walls (just the exterior walls, not roof and floors if seperately defined)?
  • Is zone.alpha_comb_outer_ow with or without radiation? We need convection and radiation seperately.
    • I think I got this solved by using zone.alpha_conv_outer_ow and zone.alpha_rad_outer_ow. Anyway, I currently define only one outdoor alphaRad, for exterior walls and windows. In TEASER, we have one alphaRad each. I now just use zone.alpha_rad_outer_ow. @PRemmen and @MichaMans, do you think this is sufficient? We could alternatively use the area weighted sum.
    • Same for ìndoor alphaRad, currently I only use zone.r_rad_inner_ow. Would be better to have the area weighted sum of all elements here. Do we already have a function for this in TEASER?
  • Is zone.t_ground in Kelvin? I assume so.
  • Can I use sum in Mako without defining it?

@mlauster
Copy link
Contributor

mlauster commented May 14, 2016

Things to solve in second step:

  • implement T_start
  • implement alphaRad
  • implement to choose whether to merge windows with outer walls or not
    • Set AWin to vector of zeros
    • Choose which equivalent air temperature model to use
    • Remove dependent models (and perhaps connections, but Modelica might be able to handle this) when false
    • Set necessary parameters in equivalentAirTemperature if true
    • For this, I need to have merge_windows within the template. This is not an attribute of the zone, right? Any suggestion how get this into the template in a samrt way? Just add it as a parameter when calling the template?
  • implement eExt for equivalent outdoor temperature (this value is fixed to 0.9 in AixLib models). This is not epso, what is the indoor part for exterior walls. espi is indoor part for interior walls.

@PRemmen
Copy link
Member Author

PRemmen commented May 15, 2016

@mlauster

Questions:

  • all values are defined in degree. As all the other code expects degree right now, I propose to do the conversion after the calculation (e.g. in the templates or in new module see comment after question part). You need to be careful with the azimut, as TEASER currently has some unconvetional way to define it (starting with 0° - North and then going clockwise).
  • For model calculation we introduced lists that explicity sort the outer walls depending on their type and needed calculation core (rooftops, outer_walls_help, groundfloors). So we can iterate easily over this list and get the area of each wall (this is a zone attribute)
  • you are right, for each kind of heat transfer we have an own resistance calculated for all walls of the same type, thus these are weighted values. So you basically could use this resistance and divide it through the certain summed area and the coefficient would be area weighted. For more details have a look in current annex branch and then 'ThermalZone.sum_building_elements', where all resistances for all elements are calculated. Later in the certain calculation function these values are combined to use them in the specific modelica model (e.g. two elements would combine outer walls, rooftops and groundfloors).
  • python does not have any units, so basically you can just set the temperature to whatever you want. However, we try to keep it all in kelvin.
  • no sure about that, maybe you need to tell mako that this is python code

General remark on Annex calculation. I propose to introduce new Python modules in the Logic.Simulation package (1. AixLib, 2. Annex). These modules contain all the functions that are needed for the model export in the certain library. E.g. for AixLib this will move the Building class functions: compare_orientations , create_time_line , modelica_set_temp, modelica_AHU_boundary, modelica_gains_boundary, out of the Building class and store them in this new module. This is advantegous as we keep all TEASER classes more or less library independent (the new ThermalZone class is completly independent from AixLib). So all calculations or sorting issues that are just needed in the Annex model should be implemented in this new module (which does not necessarly contain a class)

  • Set AWin to vector of zeros -> Move this to new module (similar to function compare_orientations)
  • Choose which equivalent air temperature -> if clause in template (similar to AixLib_model tempalte)
  • set necessary parameters -> if clause in templates
  • merge_windows and also number_of_elements, could (or even should) be input parameters for the templates as the models highly depend on these parameters (similar to AixLib building_model or zone_model, corG etc.)
  • implement eExt: @MichaMans is currently working on integrating the calculation of these values area weighted, dependend on thei building element type in the thermal zone, so this parameter will become a zone parameter sooner or later.

@mlauster
Copy link
Contributor

Are the outer wall objects and windows are sorted according to their orientation? So does the vectors of tilts, azimuts, outer walls and windows have the same order? Probably not? :-) Background of the question: I need to give vectors of tilts, azimuts, wall areas, window areas and the order of connect statements for solar radiation, and they all have to have the same order, according to their orientation.

mlauster added a commit that referenced this issue May 19, 2016
mlauster added a commit that referenced this issue May 19, 2016
MichaMans added a commit that referenced this issue May 19, 2016
…d and revised the aixlibe template, added an annex simulation module
@PRemmen
Copy link
Member Author

PRemmen commented May 22, 2016

closed by #234

@PRemmen PRemmen closed this as completed May 22, 2016
PRemmen pushed a commit that referenced this issue May 24, 2016
PRemmen pushed a commit that referenced this issue May 24, 2016
PRemmen pushed a commit that referenced this issue May 24, 2016
PRemmen pushed a commit that referenced this issue May 24, 2016
…e weightfactor sum of rooftops on building level
PRemmen pushed a commit that referenced this issue May 24, 2016
PRemmen pushed a commit that referenced this issue May 24, 2016
PRemmen pushed a commit that referenced this issue May 24, 2016
PRemmen pushed a commit that referenced this issue May 24, 2016
PRemmen pushed a commit that referenced this issue May 24, 2016
…d and revised the aixlibe template, added an annex simulation module
PRemmen pushed a commit that referenced this issue May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants