308 random sample on stream #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for this method are a bit cluncy.
menshikh-iv
suggested changes
Jun 12, 2017
gensim/test/test_wikicorpus.py
Outdated
| @@ -62,6 +63,13 @@ def test_unicode_element(self): | |||
| l = wc.get_texts() | |||
| self.assertTrue(u'папа' in next(l)) | |||
|
|
|||
| def test_sample_text(self): | |||
| wc = WikiCorpus(datapath(FILENAME_U), processes=1) | |||
| print(len(wc)) | |||
There was a problem hiding this comment.
Why do we need this line?
There was a problem hiding this comment.
This whole function should not be here. I remove it.
gensim/test/test_wikicorpus.py
Outdated
| wc = WikiCorpus(datapath(FILENAME_U), processes=1) | ||
| print(len(wc)) | ||
| for x in wc.sample_texts(1): | ||
| print(x) |
There was a problem hiding this comment.
No needed to print result in tests. You can use pass instead.
There was a problem hiding this comment.
This whole function should not be here. I remove it.
I forgot to remove test which is done in test_textcorpus.py from test_wikicorpus.py.
|
Thank you @vlejd, сongratulations on your first PR 🥇 |
menshikh-iv
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#308