Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis fix and distinct testing #1522

Merged
merged 19 commits into from
Sep 4, 2017
Merged

Conversation

menshikh-iv
Copy link
Contributor

@menshikh-iv menshikh-iv commented Aug 4, 2017

Solution for #1520 and #1518

@menshikh-iv menshikh-iv added this to In progress in Code cleanup Aug 4, 2017
@@ -118,7 +118,13 @@ echo '--------------------------------------------------------------------------
# Excluding vec files since they contain non-utf8 content and flake8 raises exception for non-utf8 input
# We need the following command to exit with 0 hence the echo in case
# there is no match
MODIFIED_FILES="$(git diff --name-only $COMMIT_RANGE -- . ':(exclude)*.vec' || echo "no_match")"
MODIFIED_PY_FILES="$(git diff --name-only $COMMIT_RANGE | grep '[a-zA-Z0-9]*.py$' || echo "no_match")"
MODIFIED_IPYNB_FILES="$(git diff --name-only $COMMIT_RANGE | grep '[a-zA-Z0-9]*.ipynb$' || echo "no_match")"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have this at all? I don't see any tests performed on .ipynb files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add it soon, it's "preparation" for testing .ipynb

script:
- pip freeze
- python setup.py test
- pip install flake8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need this line in the new script.sh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because I already add it in install script

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, I missed that, sorry.

@menshikh-iv menshikh-iv mentioned this pull request Aug 31, 2017
@menshikh-iv menshikh-iv merged commit ed0b03e into develop Sep 4, 2017
@menshikh-iv menshikh-iv moved this from In progress to Done in Code cleanup Sep 4, 2017
@menshikh-iv menshikh-iv deleted the travis-fix-and-distinct-testing branch October 6, 2017 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants