Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in KeyedVectors.wmdistance #2247

Closed
wants to merge 6 commits into from

Conversation

dnabanita7
Copy link

@dnabanita7 dnabanita7 commented Oct 31, 2018

Fix part of #2228

resolved typo as in : At least one of the documents had no words that were in the vocabulary
This was referenced Dec 4, 2018
@gojomo
Copy link
Collaborator

gojomo commented Dec 4, 2018

Thanks for the first-time contribution!

A PR may get more attention with a more descriptive title. For example, this might have caught someone's eye earlier with a title like "Fix comment typo in KeyedVectors". You can correct this via the 'edit' button to the right of the title in the Github interface. (You don't nee to open a second PR to change the title or even the mix of commits included.)

If the PR is addressing a specific issue, naming it in both the title and initial comment is helpful. (I suspect from other activity the idea to fix this may have come from #2228.) Whether the PR completely fixes the issue, or is a partial/work-in-progress fix, can be mentioned, too, to help reviewers.

At the moment, automatic tests are failing (as indicated by the red-X's shown nearby) – though that's almost certainly not the fault of this patch. It appears to be in unrelated documentation-contstruction step, and the output of that step is so large it doesn't even fully display at CircleCI. (@menshikh-iv is this a known issue someone is working on?)

@menshikh-iv
Copy link
Contributor

Hello @naba7,
thanks for PR, please

@menshikh-iv menshikh-iv changed the title Mybranch Fix typo in KeyedVectors.wmdistance Jan 8, 2019
@menshikh-iv
Copy link
Contributor

thanks for the contribution @naba7, typo already fixed in develop, closing

@menshikh-iv menshikh-iv closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants