Fix bug where opening files in GCS forgets to define a name field

[todor-markov]

Motivation

Fixes #505

Checklist

Before you create the PR, please make sure you have:

• Picked a concise, informative and complete title
• Clearly explained the motivation behind the PR
• Linked to any existing issues that your PR will be solving
• Included tests for any new functionality
• Checked that all unit tests pass

[mpenkov]

@todor-markov Thank you for making the PR! Can you add a unit test that checks for your new functionality?

[bsikander]

+1 for the PR. I have been messing with this for 2 hours now and this is the exact issue. Could we please speed up the process to get this in.

[bsikander]

Was it working in any version?

[mpenkov]

Was it working in any version?

Yes, because of this.

[bsikander]

I am new to smart-open, so, I don't understand why it was working before.

Btw, i don't understand the reason for these TODOs in the code. In added logging to my code to find the problem and got TODO multiple times. Was not helpful.
https://github.com/RaRe-Technologies/smart_open/blob/0a3619144a75ea002304c487b8f8a9ee2c867c33/smart_open/smart_open_lib.py#L403

[bsikander]

Thank you for adding the tests.

[mpenkov]

I am new to smart-open, so, I don't understand why it was working before.

This PR adds .name attribute to file objects created by the GCS backend. Previously, this attribute was missing. However, the code that relied on the .name attribute was robust enough to handle its absense.

Btw, i don't understand the reason for these TODOs in the code. In added logging to my code to find the problem and got TODO multiple times.

TODOs serve as a reminder to developers about parts of the code that are incomplete (or require attention for whatever reason). They are not ideal - in retrospect, it would have been better to fix the underlying problem, or create a github ticket to track the issue. Hindsight is always 20/20.

Was not helpful.

You're welcome to make PRs to make things more helpful.

[mpenkov]

Thank you @todor-markov ! Congratulations on your first contribution to smart_open 🥇