Fix FTP write functionality by sending additional FTP command #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks! |
|
@mpenkov Thank you. Is there a new release scheduled for this? |
|
I'll try to release within one or two weeks. I'd like to get #748 merged in first. |
|
(if you're able to help, please see the discussion in that thread) |
beck3905
added a commit
to beck3905/smart_open
that referenced
this pull request
Sep 6, 2023
mpenkov
pushed a commit
that referenced
this pull request
Sep 7, 2023
* fix: ignore seek requests to the current position * fix: adjust test to match new seek behavior * run seek if it is the first time * Add required import for example to work (#756) If a person were to simply copy this code block it would use the built in `open` and would not work. Adding in the correct import makes this block a bit easier for a simple copy paste. * run tests on py3.11 (#774) * add type command to ftp (#781) * Add python 3.11 to setup.py (#775) * Fixes KeyError when retrieving empty but existing object from S3 (#771) * fix: Fixes KeyError when retrieving empty file from S3 * Add test * bugfix: when read size > chunk size, return read size and not chunk size (#767) * undo formatting * fix whitespace * undo formatting --------- Co-authored-by: Rusty Conover <rusty@conover.me> Co-authored-by: Christian Jensen <christian@orbik.com> Co-authored-by: tooptoop4 <33283496+tooptoop4@users.noreply.github.com> Co-authored-by: Raphaël Cohen <raphael.cohen.utt@gmail.com> Co-authored-by: Ron Reiter <ron.reiter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix FTP write functionality by sending additional FTP command
Motivation
Writing to an FTP server will fail because ASCII is not supported, but the existing ftp module does not correctly store data in binary mode.
Based on the builtin
ftplib.FTP.storbinary()method, sending an additionalTYPE Icommand to the FTP server will set theSTORcommand to binary mode and allow the write operation to proceed.Fixes #780