Fixes KeyError when retrieving empty but existing object from S3 #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darkheir
force-pushed
the
fix/s3_empty_file
branch
from
82f75e7
to
cd9dbac
Compare
|
Can you please add a test? |
|
A test has been added :) |
|
Do you need anything more to be done in the PR before merging it ? |
|
No, please leave it with me. I'm a little busy with other stuff at the moment, sorry. |
mpenkov
changed the title
mpenkov
changed the title
|
Thank you @Darkheir ! |
beck3905
pushed a commit
to beck3905/smart_open
that referenced
this pull request
Sep 6, 2023
…kvorky#771) * fix: Fixes KeyError when retrieving empty file from S3 * Add test
mpenkov
pushed a commit
that referenced
this pull request
Sep 7, 2023
* fix: ignore seek requests to the current position * fix: adjust test to match new seek behavior * run seek if it is the first time * Add required import for example to work (#756) If a person were to simply copy this code block it would use the built in `open` and would not work. Adding in the correct import makes this block a bit easier for a simple copy paste. * run tests on py3.11 (#774) * add type command to ftp (#781) * Add python 3.11 to setup.py (#775) * Fixes KeyError when retrieving empty but existing object from S3 (#771) * fix: Fixes KeyError when retrieving empty file from S3 * Add test * bugfix: when read size > chunk size, return read size and not chunk size (#767) * undo formatting * fix whitespace * undo formatting --------- Co-authored-by: Rusty Conover <rusty@conover.me> Co-authored-by: Christian Jensen <christian@orbik.com> Co-authored-by: tooptoop4 <33283496+tooptoop4@users.noreply.github.com> Co-authored-by: Raphaël Cohen <raphael.cohen.utt@gmail.com> Co-authored-by: Ron Reiter <ron.reiter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Attempt to fix the
KeyErrorwe have when reading an empty file from S3Motivation
When we try to retrieve an empty file from S3 we may have the following error
This PR catches the
KeyErrorand send aget_objectquery without any range to retrieve the data as suggested in the issueTests
I added a test, but it seems that the Moto lib provide the value
ActualObjectSizeeven for empty objects so the code won't be tested...