Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for line-height #35

Merged
merged 3 commits into from Jun 10, 2019
Merged

Conversation

Winner95
Copy link

@Winner95 Winner95 commented Jun 9, 2019

Hello,

First of all, thank you for making this tool for visual work with css properties!

And I think it is important to support line-height in plugin for building visual typography in css / ui components.

I hope it will be helpful.

@paustint paustint added the 👍 Enhancement New feature or request label Jun 9, 2019
@paustint
Copy link
Collaborator

paustint commented Jun 9, 2019

@Raathigesh - The code and UI LGTM.

Also, I wonder if we should run prettier on the entire codebase to update everything to make it consistent, so that future PRs do not include a ton of style changes that are unrelated to the actual commit.
example:
On this PR, @Winner95 had prettier change all sorts of code:
bbd9a48 (Prettier made lots of changes)
Then @Winner95 reverted the prettier applied prettier changes:
bbd9a48 (Submitter reverted prettier changes to limit changes that were not related to specific code updates)

@Raathigesh Thoughts?

image

@paustint paustint added this to In Review in Development Board via automation Jun 9, 2019
@Raathigesh
Copy link
Owner

@Winner95 Thank you for the PR. Looks good to me too 👍

@paustint I agree we should do a prettier run on the codebase. Will do.

@Raathigesh
Copy link
Owner

@all-contributors please add @Winner95 for code

@allcontributors
Copy link
Contributor

@Raathigesh

I've put up a pull request to add @Winner95! 🎉

@Raathigesh Raathigesh merged commit 2c6f566 into Raathigesh:master Jun 10, 2019
Development Board automation moved this from In Review to Done Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants