Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve Debian issues #40

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Solve Debian issues #40

wants to merge 5 commits into from

Conversation

MaGaroo
Copy link

@MaGaroo MaGaroo commented Jun 29, 2024 •
edited
Loading

Hey. There were three problems:

  1. virtualenv didn't setup correctly in my Ubuntu 22.04. There was no file as venv/bin/activate
  2. Python virtualenv isn't used while using sudo. Someone tried to resolve it in Readme and Linux fixes.  #21 , but I think it was really nasty and my approach is better.
  3. If a step fails, script continues. It's ridiculous and it must not!!

Feel free to give feedback. Feel free to reject PR. Whatever you prefer. 😂

@AgentFabulous
Copy link
Contributor

AgentFabulous commented Jun 30, 2024 •
edited
Loading

I agree, I like your approach better, however we must keep in mind that sudo is not necessary to run mtkclient on Linux. Can’t this be a wrapper on invoking the script, or similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaGaroo @AgentFabulous