feat: + 1142 rule (#21)

* feat: + 1142 rule * 1.1.21 * feat: remove nft approve trust value rule * 1.1.22
RabbyHub · May 29, 2024 · 16e61c1 · 16e61c1
1 parent 4be0274
commit 16e61c1
Show file tree

Hide file tree

Showing 5 changed files with 91 additions and 69 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@rabby-wallet/rabby-security-engine",
-  "version": "1.1.20",
+  "version": "1.1.22",
   "description": "",
   "main": "dist/index.js",
   "scripts": {

diff --git a/src/rules/collectionApprove.ts b/src/rules/collectionApprove.ts
@@ -18,40 +18,40 @@ const rules: RuleConfig[] = [
       return isEOA;
     },
   },
-  {
-    id: "1054",
-    enable: true,
-    valueDescription: "Trust value",
-    valueTooltip:
-      "Trust value refers to the top NFT approved and exposed to this contract. A low trust value indicates either risk or inactivity for 180 days.",
-    valueDefine: {
-      type: "int",
-      min: 0,
-      minIncluded: true,
-      max: null,
-      maxIncluded: false,
-    },
-    defaultThreshold: {
-      danger: {
-        min: 0,
-        minIncluded: true,
-        max: 10000,
-        maxIncluded: true,
-      },
-      warning: {
-        min: 10000,
-        minIncluded: false,
-        max: 100000,
-        maxIncluded: true,
-      },
-    },
-    customThreshold: {},
-    requires: ["collectionApprove"],
-    async getValue(ctx) {
-      const data = ctx.collectionApprove!;
-      return data.riskExposure;
-    },
-  },
+  // {
+  //   id: "1054",
+  //   enable: true,
+  //   valueDescription: "Trust value",
+  //   valueTooltip:
+  //     "Trust value refers to the top NFT approved and exposed to this contract. A low trust value indicates either risk or inactivity for 180 days.",
+  //   valueDefine: {
+  //     type: "int",
+  //     min: 0,
+  //     minIncluded: true,
+  //     max: null,
+  //     maxIncluded: false,
+  //   },
+  //   defaultThreshold: {
+  //     danger: {
+  //       min: 0,
+  //       minIncluded: true,
+  //       max: 10000,
+  //       maxIncluded: true,
+  //     },
+  //     warning: {
+  //       min: 10000,
+  //       minIncluded: false,
+  //       max: 100000,
+  //       maxIncluded: true,
+  //     },
+  //   },
+  //   customThreshold: {},
+  //   requires: ["collectionApprove"],
+  //   async getValue(ctx) {
+  //     const data = ctx.collectionApprove!;
+  //     return data.riskExposure;
+  //   },
+  // },
   {
     id: "1055",
     enable: true,

diff --git a/src/rules/index.ts b/src/rules/index.ts
@@ -77,6 +77,8 @@ export interface ContextActionData {
     isTokenContract: boolean;
     usedChainList: string[];
     onTransferWhitelist: boolean;
+    hasReceiverMnemonicInWallet: boolean;
+    hasReceiverPrivateKeyInWallet: boolean;
   };
   permit?: {
     spender: string;
@@ -128,6 +130,8 @@ export interface ContextActionData {
     } | null;
     usedChainList: string[];
     onTransferWhitelist: boolean;
+    hasReceiverMnemonicInWallet: boolean;
+    hasReceiverPrivateKeyInWallet: boolean;
   };
   nftApprove?: {
     chainId: string;

diff --git a/src/rules/nftApprove.ts b/src/rules/nftApprove.ts
@@ -19,40 +19,40 @@ const rules: RuleConfig[] = [
       return isEOA;
     },
   },
-  {
-    id: "1044",
-    enable: true,
-    valueDescription: "Trust value",
-    valueTooltip:
-      "Trust value refers to the top NFT approved and exposed to this contract. A low trust value indicates either risk or inactivity for 180 days.",
-    valueDefine: {
-      type: "int",
-      min: 0,
-      minIncluded: true,
-      max: null,
-      maxIncluded: false,
-    },
-    defaultThreshold: {
-      danger: {
-        min: 0,
-        minIncluded: true,
-        max: 10000,
-        maxIncluded: true,
-      },
-      warning: {
-        min: 10000,
-        minIncluded: false,
-        max: 100000,
-        maxIncluded: true,
-      },
-    },
-    customThreshold: {},
-    requires: ["nftApprove"],
-    async getValue(ctx) {
-      const data = ctx.nftApprove!;
-      return data.riskExposure;
-    },
-  },
+  // {
+  //   id: "1044",
+  //   enable: true,
+  //   valueDescription: "Trust value",
+  //   valueTooltip:
+  //     "Trust value refers to the top NFT approved and exposed to this contract. A low trust value indicates either risk or inactivity for 180 days.",
+  //   valueDefine: {
+  //     type: "int",
+  //     min: 0,
+  //     minIncluded: true,
+  //     max: null,
+  //     maxIncluded: false,
+  //   },
+  //   defaultThreshold: {
+  //     danger: {
+  //       min: 0,
+  //       minIncluded: true,
+  //       max: 10000,
+  //       maxIncluded: true,
+  //     },
+  //     warning: {
+  //       min: 10000,
+  //       minIncluded: false,
+  //       max: 100000,
+  //       maxIncluded: true,
+  //     },
+  //   },
+  //   customThreshold: {},
+  //   requires: ["nftApprove"],
+  //   async getValue(ctx) {
+  //     const data = ctx.nftApprove!;
+  //     return data.riskExposure;
+  //   },
+  // },
   {
     id: "1045",
     enable: true,

diff --git a/src/rules/send.ts b/src/rules/send.ts
@@ -108,6 +108,24 @@ const rules: RuleConfig[] = [
       return onTransferWhitelist;
     },
   },
+  {
+    id: "1142",
+    enable: true,
+    valueDescription: "The recipient address is from your seed phrase",
+    valueDefine: {
+      type: "boolean",
+    },
+    defaultThreshold: {
+      safe: true,
+    },
+    customThreshold: {},
+    requires: ["send", "sendNFT"],
+    async getValue(ctx) {
+      const { hasReceiverMnemonicInWallet, hasReceiverPrivateKeyInWallet } =
+        ctx.send!;
+      return hasReceiverMnemonicInWallet || hasReceiverPrivateKeyInWallet
+    },
+  },
 ];
 
 export default rules;