refactor(game): begin refactoring into a game state and game level pa… #20
Conversation
| if (gamestate.playing) config.world.step(1/60); | ||
| config.renderer.render(config.stage); | ||
| } | ||
| } |
|
Could we name Class-exporting files by caps like we've been doing? |
|
also uh, commit message length |
|
Is that how they're capitalized? It seemed mostly random to me. I would prefer if either all files are capitalized or none of them are because that's a mostly-useless notation if the file structure makes sense (currently everything is just in one folder, so this will require a bit of a re-org). Also, if we want to enforce commit message length we should probably have a bot for that (gitcop is ok). |
|
Just fix your vim or whatever you commit with so that it enforces 50colunns message, 72 columns description |
|
I use the terminal to commit, but you haven't given my a reason why I should care about commit message length. I don't do things without a sufficient reason why. |
|
It cuts off the description in git. Describe what you can in the message and then dump the rest in the description. Be concise. Also >72 lines description wraps badly in terminals. |
|
Make your terminal larger ???? idk, I'm not rebasing or changing messages but we'll see going forward. |
|
Fine I'll just fix your commits for you when I get home. Also git does it regardless of your terminal size. |
refactor(game): begin refactoring into a game state and game level pa…
…ttern