Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added -c -config parser argument #12

Merged
merged 6 commits into from
Oct 5, 2023
Merged

added -c -config parser argument #12

merged 6 commits into from
Oct 5, 2023

Conversation

pbelokon
Copy link
Contributor

@pbelokon pbelokon commented Oct 3, 2023

Acceptance criteria for the feature:

  • The -c or --config flags accept a file path to a TOML-based config file.
  • If the file is missing, or can't be parsed as TOML, exit with an appropriate error message.
  • If the -c or --config option is provided, ignore all other options (i.e., a config file overrides other options on the command line).
  • The program should ignore any options in the config file it doesn't recognize. For example, if the app doesn't support stylesheets, ignore a stylesheet property.
  • If the config file is missing any options, assume the usual defaults.
  • User is able to pass TOML file and it applies to HTML

@pbelokon
Copy link
Contributor Author

pbelokon commented Oct 3, 2023

@Rachit1313 just wanted to ask you to do a quick review of my changes, and tell me if i should change anything.

@Rachit1313 Rachit1313 self-requested a review October 4, 2023 01:28
@Rachit1313 Rachit1313 marked this pull request as ready for review October 4, 2023 01:28
@Rachit1313 Rachit1313 self-assigned this Oct 4, 2023
@Rachit1313
Copy link
Owner

Hi,
Thank you for the implementation.
Could you also update the documentation on this?

Thank you

@Rachit1313
Copy link
Owner

I checked your code changes and its good. Once you make the changes in the documentation, I will be merging this pull request after reviewing it.

@pbelokon
Copy link
Contributor Author

pbelokon commented Oct 4, 2023

Thanks, sure I ll update this pr tomorrow

@Rachit1313 Rachit1313 assigned pbelokon and unassigned Rachit1313 Oct 4, 2023
@Rachit1313 Rachit1313 added the enhancement New feature or request label Oct 4, 2023
@pbelokon
Copy link
Contributor Author

pbelokon commented Oct 4, 2023

@Rachit1313 I committed some changes to the README could you check it out

@Rachit1313 Rachit1313 merged commit af062d2 into Rachit1313:main Oct 5, 2023
1 check passed
@Rachit1313
Copy link
Owner

Thank you for your PR. Merged.

@Rachit1313 Rachit1313 linked an issue Oct 5, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add -c and --config flag with TOML based Config File
2 participants