Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name fix #29

Merged
merged 2 commits into from Nov 22, 2016
Merged

Name fix #29

merged 2 commits into from Nov 22, 2016

Conversation

ekaley
Copy link

@ekaley ekaley commented Nov 22, 2016

DEPENDS on #28

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.518% when pulling 770d92a on name_fix into 2c94e06 on master.

king-jam
king-jam approved these changes Nov 22, 2016
View reviewed changes
Copy link
Contributor

@king-jam king-jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting works for now to clarify, do we want to put a story to change the actual variables?

@king-jam king-jam merged commit 38a255c into master Nov 22, 2016
@king-jam king-jam deleted the name_fix branch November 22, 2016 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrey jfrey jfrey approved these changes

@king-jam king-jam king-jam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ekaley @coveralls @jfrey @king-jam