Feature/ibms #257
Merged
Feature/ibms #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple AMPQ servers are passed to amqp library as an array inside an object. This changes the check of the parameter as an object instead of an array.
Change check for multiple amqp URIs from an array to an object.
* Hook features need database model and method to post data to user provided url * Hook model is created as well as hook publish method in the PR * Hook publish method leverage http tool, thus http tool is moved from on-task repo to lib/common
* Update review comments:
1. Add negative tests for hook publish method
2. Use nock.cleanAll() for nock unit test
3. Use done(new Error) instead of throw(new Error)
* Hook feature should be called together with external event as a
service.
* Thus hook service is created and existing hook feature unit test is
moved from lib/common/hook-spec.js to lib/services/hook-spec.js.
* Hook publish is added to publishExternalEvent method.
Implement hook feature
* To let user subscribe interested data, filter is designed based on event message header for hook feature. * User filter should be a Javascript style RE expression as a string in the design. * All data will be filtered against user defined hook filters and only qualified data will be posted to webhook url
Implement hook filter feature
dalebremner
pushed a commit
to dalebremner/on-core
that referenced
this pull request
Dec 1, 2017
…ll-timeout-amqp OS installer timeout option and reformat default AMQP output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating with master, again