ON-2719 - Add additional POST workflow route necessary to #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support node refresh workflow.
|
Are additional unit tests required for this? |
|
Yeah, tests would be nice, though given my comment in #107 this may end up just being a quick fix for 1.1. @jimturnquist hit me up on slack and I can walk you through our unit testing approach if you need it/help you whip up a simple test for this. |
| var graph = { name: 'foobar' }; | ||
| taskGraphRunner.runTaskGraph.resolves(graph); | ||
|
|
||
| return helper.request().post('/api/1.1/workflows') |
|
👍 Thanks Jim! |
| return helper.request().post('/api/1.1/workflows') | ||
| .send(graph) | ||
| .expect('Content-Type', /^application\/json/) | ||
| .expect(200, graph); |
There was a problem hiding this comment.
A check to ensure runTaskGraph was called may be a nice addition
|
Could use additional checking in unit tests and addition of functional tests at: https://github.com/RackHD/RackHD/blob/master/test/tests/workflows_tests.py, but the code looks fine to merge as is. +1. |
|
👍 |
benbp
added a commit
that referenced
this pull request
Feb 4, 2016
ON-2719 - Add additional POST workflow route necessary to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ON-2719 - Add additional POST workflow route necessary to support node refresh workflow.
@benbp