[1.2] Set bmc ip only when ip source is static when flashing quanta bmc #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iceiilin
changed the title
|
👍 |
2 similar comments
|
👍 |
|
👍 |
|
if some PR message is also added to codes annotation, it's more readable in future's codes maintaince |
iceiilin
force-pushed
the
bugfix/1.2.0-odr726-bios
branch
from
d8222e0
to
998af96
Compare
|
@anhou add comments. |
|
Thanks @iceiilin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ODR 771 in flashing quanta BMC scripts, about error to set BMC IP after flashing Quanta BMC, if ip source is DHCP.
It happened in MN lab, where BMC IP source is DHCP. Though the "sudo ipmitool lan set 1 ipaddr xxx" after flashing returns the same message as in static IP source, the exit code is 1 rather than 0. Modify the script to skip these network setting steps if the source is DHCP.
Add retry count after mc reset so that total wait time (maximum) is 90s, the same as suggested by vendor after flashing BMC. The original value is 60s, which is not sufficient for stack 13 node 1 at a certain ratio.
@uppalk1 @zyoung51