[RAC-6211] Port Redfish Get Inventory feature underlying implementation from Racadm to WSMAN #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BUILD on-http #635 : FAILURE |
|
BUILD on-http #637 : FAILURE |
|
test this please |
yaolingling
reviewed
Oct 27, 2017
| } | ||
| xmlParser(fqddString, function (err, result) { | ||
| if(err){ | ||
| return; |
There was a problem hiding this comment.
It's better to add logger.error or throw error
| expect(response.body).to.have.property('message', 'test'); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
It' better to add case for success
There was a problem hiding this comment.
Other cases had been covered. This case is specified for the error case.
yaolingling
approved these changes
Oct 27, 2017
anhou
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Based on the preceding investigation work, start to port redfish get inventory underlying implementation from Racadm with WSMAN API.
Details
Reviewer
@leoyjchang @nortonluo @lanchongyizu @yaolingling @anhou