add deleting all types of nodes #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| describe("removeNode", function() { | ||
| before("removeNode before", function() { |
This was referenced Jan 8, 2016
|
This PR depend on on-core PR RackHD/on-core#62 for constants definition and unit test. |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
👍 |
1 similar comment
|
👍 |
|
There is no clue about the Jenkins failure, perhaps it is a trial run? Will try to merge and monitor the smoke test report. |
anhou
pushed a commit
that referenced
this pull request
Jan 14, 2016
add deleting all types of nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to 1.1.0 branch, the same with #80 that has been merged into master.
It is a fix of ODR-314 required for 1.1.0. Implement full function about deleting nodes and update its related ones based on "relations" field in nodes/ document.
Dependent on PR:
RackHD/on-core#62