Feature/use local package json #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
test this please |
|
@RackHD/corecommitters |
sushilrai
pushed a commit
to sushilrai/on-taskgraph
that referenced
this pull request
Dec 5, 2017
* commit '3a37d8a839f5540718c69bba2ed3bea04614ef25': MAG-164 improve unit test case to cover drive error status MAG-164 IPMI Drive health status poller(ORFS-29)
sushilrai
pushed a commit
to sushilrai/on-taskgraph
that referenced
this pull request
Dec 5, 2017
support specify install disk for install-os
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change copies the local package.json file to the packagebuild directory, and does so because that file might be modified during the manifest build to reference dependency modules that are satisfied using references from the manifest file.
For example, the dependency of
might be changed to:
during the build process, and then npm will use the version of on-core that's been checked out as per the detailed build manifest.
This change also ensures that errors in the build process are propagated upward (via set -e) so that failures in the ./HWIMO-BUILD process will be noticed upstream.