RHEL 7.2 installation support #568
Conversation
ScaleIO storage-only nodes on RHEL require custom RPM packages to be installed and to have disk partitions cleared. This adds that support into the RackHD Graph.InstallRHEL workflow. The changes have been submitted upstream as: - RackHD/on-taskgraph#343 - RackHD/on-tasks#568
| "description": "a flag to indicate whether partitions of non-installation should be cleared", | ||
| "type": "boolean" | ||
| }, | ||
| "Kdump": { |
There was a problem hiding this comment.
Adding a field 'Kdump' is not a general way, if others want to add other items want to disable/enable by systemctl, more fields will be added, it's not so good. so either controlling it by puppet/ansible/.. after os installation, or adding a more general way for things which could be controlled by 'systemctl'
There was a problem hiding this comment.
Thanks for the suggestion. Removed kdump from the PR. Will add support for providing the list of services that needs to be enabled / disabled during the post-installation.
| }, | ||
| "uniqueItems": true | ||
| }, | ||
| "ClearDisk": { |
There was a problem hiding this comment.
I didn't see 'clearDisk' related codes in RackHD/on-taskgraph#343.
There was a problem hiding this comment.
Removed 'clearDisk' from the PR. Observed some failures after rebooting the server due to 'dd' of non-installation disks. Investigating other options. Will push a separate PR for cleanup of non-OS installation disks
sushilrai
force-pushed
the
rhel72
branch
2 times, most recently
from
233ed64
to
19b89dd
Compare
ScaleIO storage-only nodes on RHEL require custom RPM packages to be installed and to have disk partitions cleared. This adds that support into the RackHD Graph.InstallRHEL workflow. The changes have been submitted upstream as: - RackHD/on-taskgraph#343 - RackHD/on-tasks#568
ScaleIO storage-only nodes on RHEL require custom RPM packages to be installed and to have disk partitions cleared. This adds that support into the RackHD Graph.InstallRHEL workflow. The changes have been submitted upstream as: - RackHD/on-taskgraph#343 - RackHD/on-tasks#568
ScaleIO storage-only nodes on RHEL require custom RPM packages to be installed and to have disk partitions cleared. This adds that support into the RackHD Graph.InstallRHEL workflow. The changes have been submitted upstream as: - RackHD/on-taskgraph#343 - RackHD/on-tasks#568
| @@ -50,6 +50,9 @@ | |||
| "networkDevices": { | |||
| "$ref": "types-installos.json#/definitions/NetworkDeviceArray" | |||
| }, | |||
| "bonds": { | |||
There was a problem hiding this comment.
@sushilrai I re-think about 'bonds' field, maybe 'bonds' is also one type of networkDevices interfaces, right? so 'bond' could be at the same level with 'eth0' 'eth1' , and it could be one value of 'device' under 'networkDevices' http://rackhd.readthedocs.io/en/latest/rackhd/install_os.html#networkdevices, right?
If I missunderstand something, please point out
There was a problem hiding this comment.
Bonds networks are defined separately for simplicity. These logical interfaces requires different configuration parameters as compared to normal physical interfaces.
Also we need to configure the bond interfaces before the normal interfaces to avoid any conflict.
@anhou please confirm if we need to include the bond interfaces in networkDevices then I will make necessary changes
There was a problem hiding this comment.
@sushilrai make sense for me that it's logical device that has different configurations. +1
| "type": "string" | ||
| }, | ||
| "nics": { | ||
| "description": "the ipv4 configuration for this interface", |
There was a problem hiding this comment.
I guess it's copied from 'ipv4', it could be refined
|
Could you also help update the document? the docs repo is https://github.com/RackHD/docs. I think at least these two parts could be included. 1. include RHEL 7.2 support in the OS support table at http://rackhd.readthedocs.io/en/latest/rackhd/install_os.html#supported-os-installation-workflows, and update the payloads table at http://rackhd.readthedocs.io/en/latest/rackhd/install_os.html#non-windows-os-installation-workflow-payload, because some fields are only avalable at RHEL/CentOS, so please also help note (RHEL/CentOS only) in the docs. If you have any questions, let me know |
|
PR RackHD/docs#419 is submitted with documentation change |
|
Thanks @sushilrai ! |
sushilrai
force-pushed
the
rhel72
branch
2 times, most recently
from
481a3f2
to
b17123d
Compare
spec/lib/jobs/install-os-spec.js
Outdated
| } | ||
| ]; | ||
| job._validateOptions(); | ||
| expect(job.options.networkDevices.length).to.equal(1) |
spec/lib/jobs/install-os-spec.js
Outdated
| } | ||
| ]; | ||
| job._validateOptions(); | ||
| expect(job.options.networkDevices.length).to.equal(1) |
- Added support for additional packages - NIC Bond - MTU configuration - Configuring IP gateway as option to non-routable networks - Enable / Disable list of services
|
@anhou I have added change for OS installation and have added relevant tests to cover new changes. As per test coverage, we are having lesser coverage for base installation. Please let me know if we are good to merge this PR or I need to add some tests to |
|
@sushilrai we're looking at why concourse-ci fail, that's blocking the merge. |
Supporting PR for RackHD/on-taskgraph#343